Breadway/bread-ecosystem
1
0
Fork 0
Code Issues 8 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Gate cargo fmt --check in CI #26

Merged
Breadway merged 2 commits from fix/eco-21-fmt-gate-bread-ecosystem into main 2026-09-11 18:48:46 +08:00
Conversation 0 Commits 2 Files changed 29 +337 -131
Breadway commented 2026-09-11 11:33:54 +08:00
Owner
Copy link

Normalises the tree with a dedicated cargo fmt --all commit, adds that commit's SHA to a new .git-blame-ignore-revs, and adds a cargo fmt --all -- --check step to check.yml (the step check.yml's own comment said was pending until the tree was normalised).

Two commits: formatting only, then the CI/blame-ignore change, so the reformat is easy to skip when reading blame or reviewing history.

Verified locally: cargo fmt --all -- --check, cargo clippy --workspace --all-targets --locked -- -D warnings (with and without --features gtk), and cargo test --workspace --locked (with and without --features gtk), all clean.

Part of ECO-21 (bread-ecosystem half; bos-settings gets its own PR).

Normalises the tree with a dedicated `cargo fmt --all` commit, adds that commit's SHA to a new `.git-blame-ignore-revs`, and adds a `cargo fmt --all -- --check` step to `check.yml` (the step check.yml's own comment said was pending until the tree was normalised). Two commits: formatting only, then the CI/blame-ignore change, so the reformat is easy to skip when reading blame or reviewing history. Verified locally: `cargo fmt --all -- --check`, `cargo clippy --workspace --all-targets --locked -- -D warnings` (with and without `--features gtk`), and `cargo test --workspace --locked` (with and without `--features gtk`), all clean. Part of ECO-21 (bread-ecosystem half; bos-settings gets its own PR).
Normalises the whole tree ahead of gating cargo fmt --check in CI.
Formatting only, no behavior change.
ci: gate cargo fmt --check in check.yml
All checks were successful
check / check (push) Successful in 2m22s
Details
ba4d8105b2 
Adds the fmt commit's SHA to .git-blame-ignore-revs and enables the
fmt step check.yml's own comment said was pending until the tree was
normalised.
Breadway deleted branch fix/eco-21-fmt-gate-bread-ecosystem 2026-09-11 18:48:46 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bread-theme

   
breadbug

   
bug

   
ci

   
enhancement

   
phase-2

   
release

   
rollout
No labels
bread-theme
breadbug
bug
ci
enhancement
phase-2
release
rollout
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Breadway/bread-ecosystem!26
No description provided.