bread-theme: drop pywal from packaging/docs and release #33
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Once the extractor, cache path and sequences land:
optional_system_deps = ["python-pywal"]frombread-theme/bakery.toml.src/bin/bread-theme.rs(--imageno longer "isolated wal -i";--from-jsonstill accepts wal-shape JSON).Part of epic PYWAL.
PR: #36
Dropped python-pywal from bakery.toml, reworded Cargo.toml/registry descriptions and CLI help, updated README/BREAD_DESIGN_SYSTEM.md/docs/shell-themes.md/CHANGELOG. Release NOT cut as part of this PR per instructions; the bread-ecosystem release should go out after this merges and before any consumer (breadpaper etc.) is updated to depend on the new API.
Reviewed on bread-ecosystem#36. The packaging and docs changes are fine (python-pywal dropped from bakery.toml, descriptions and help reworded). One stale doc belongs with the ECO-30 rework: output.rs:164-168 still describes "median cut / hue spread". Not merged, because it ships in the same PR as ECO-29/30, which need rework. Left in review.
Second-round review: ready. python-pywal is gone from bread-theme's bakery.toml, and the registry, docs, CLI help and Cargo metadata are reworded. Optional nit: pywal still appears in code comments and theme asset comments (adw.rs, gtk.rs, layerrules.rs, shell/, assets/shell//theme.toml; the list is on the PR). The crate licence changed to
MIT AND ImageMagick AND IJG AND BSD-3-Clause, which needs the user's sign-off (see #36 (comment)). This stays in review because it lands with bread-ecosystem#36.Landed with the round-3 push to bread-ecosystem#36 (commit
c29a829): reworded the remaining pywal comments in adw.rs/gtk.rs/layerrules.rs/shell//assets/shell//theme.toml, keeping mentions where pywal-compatibility is the actual point. The licensing sign-off flagged in the last review is resolved per the user's decision: bread-theme is plain MIT again, the ImageMagick/IJG code lives in a new bread-palette-extract crate behind an opt-in feature. Staying in review since it ships in the same PR as ECO-30.