CI clippy fails on runner Rust 1.99.0: double_must_use on the async_trait Adapter trait #52

New issue

Open

opened 2026-10-20 15:41:45 +08:00 by Breadway · 0 comments

Breadway commented

2026-10-20 15:41:45 +08:00

Owner

How it was found: independent review of bread PR 50 (ECO-81) at 825120bd. Its only commit status, check / check (push), failed in clippy although the diff touches only two workflow files and no Rust.

Confidence: medium. The failing lint is reported by the reviewer from the run 188 log. Run 189 on an unrelated branch (fix/bread-35-...) fails with the same three errors, and run 187 on the identical Rust tree passed about 20 minutes earlier. That points to toolchain drift on the self-hosted runner, but the runner's Rust version change was inferred, not observed. I could not reproduce it locally: my rustc is 1.97.1.

Bug: clippy on Rust 1.99.0 reports double_must_use at breadd/src/adapters/mod.rs:32, the #[async_trait] pub trait Adapter. The repo's check.yml runs clippy with -D warnings, so every PR to bread fails check until this is fixed or the toolchain is pinned. main's last recorded check passed, so main is not red; PRs are.

What to do: confirm the runner toolchain version, then either fix the lint at the source or pin the toolchain in the CI container (ci/bread-ecosystem.rev points at the shared image). Do not allow the lint.

Impact: blocks a green check on bread PRs 50 (ECO-81), the BREAD-35 branch, and any other open bread PR.

**How it was found:** independent review of bread PR 50 (ECO-81) at 825120bd. Its only commit status, check / check (push), failed in clippy although the diff touches only two workflow files and no Rust. **Confidence:** medium. The failing lint is reported by the reviewer from the run 188 log. Run 189 on an unrelated branch (fix/bread-35-...) fails with the same three errors, and run 187 on the identical Rust tree passed about 20 minutes earlier. That points to toolchain drift on the self-hosted runner, but the runner's Rust version change was inferred, not observed. I could not reproduce it locally: my rustc is 1.97.1. **Bug:** clippy on Rust 1.99.0 reports `double_must_use` at breadd/src/adapters/mod.rs:32, the `#[async_trait] pub trait Adapter`. The repo's check.yml runs clippy with -D warnings, so every PR to bread fails check until this is fixed or the toolchain is pinned. main's last recorded check passed, so main is not red; PRs are. **What to do:** confirm the runner toolchain version, then either fix the lint at the source or pin the toolchain in the CI container (ci/bread-ecosystem.rev points at the shared image). Do not allow the lint. **Impact:** blocks a green check on bread PRs 50 (ECO-81), the BREAD-35 branch, and any other open bread PR.