Breadway/breadarr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix all cargo clippy warnings across the workspace
Some checks failed
check / check (push) Failing after 53s
Details

Browse source 
Removes genuinely dead code (unused import, no-op cast, an unused
PendingGrab accessor, and TmdbClient's TV-search methods now that TVDB
fully covers that path), tightens len()>0 checks to is_empty(), swaps
two fixed-size test vec!s for arrays, restructures a match to avoid an
unnecessary unwrap_err, fixes doc-comment list indentation, and hoists
a locked-connection call out of a match scrutinee. Struct fields/enum
variants that are still meaningful but not read by current callers
(TorrentInfo::save_path, GrabCycleStats::items_seen, X1337 fallback
route, BacklogCandidate::path) get #[allow(dead_code)] rather than
deletion, same for the two 8-argument functions (too_many_arguments).
This commit is contained in:
Breadway 2026-08-06 08:51:07 +08:00
parent 471ca884a6
commit 5543485976
9 changed files with 32 additions and 106 deletions
Download patch file Download diff file Expand all files Collapse all files

14
breadarrd/src/importer/mod.rs
View file

@ -99,14 +99,6 @@ impl PendingGrab {
PendingGrab::Movie { .. } | PendingGrab::SeasonPack { .. } => None,
}
}
fn root_folder(&self) -> &str {
match self {
PendingGrab::Episode { root_folder, .. }
| PendingGrab::Movie { root_folder, .. }
| PendingGrab::SeasonPack { root_folder, .. } => root_folder,
}
}
}
/// Three separate queries (rather than one `LEFT JOIN episode`) because a
@ -1615,7 +1607,7 @@ impl StaleFile {
/// later step (free-space check, the actual move) fails, so a failed
/// import never leaves neither the old file nor the new one behind.
fn restore(&self) {
if self.parked_at.as_os_str().len() > 0 {
if !self.parked_at.as_os_str().is_empty() {
std::fs::rename(&self.parked_at, &self.restore_to).ok();
}
}
@ -1909,7 +1901,7 @@ fn import_one(
if let Some(row_id) = stale.row_id {
conn.execute("DELETE FROM episode_file WHERE id = ?1", params![row_id])?;
}
if stale.parked_at.as_os_str().len() > 0 {
if !stale.parked_at.as_os_str().is_empty() {
std::fs::remove_file(&stale.parked_at).ok();
}
}
@ -2309,7 +2301,7 @@ fn import_season_pack_file(
if let Some(row_id) = stale.row_id {
conn.execute("DELETE FROM episode_file WHERE id = ?1", params![row_id])?;
}
if stale.parked_at.as_os_str().len() > 0 {
if !stale.parked_at.as_os_str().is_empty() {
std::fs::remove_file(&stale.parked_at).ok();
}
}