Breadway/breadarr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix literal-tilde fallback bug in breadarr-shared's expand_home

Browse source 
expand_home() fell through to PathBuf::from(input) — the literal,
unexpanded "~/..." string — whenever the HOME env var itself wasn't set,
same bug class as breadclip-core/breadpad-shared/breadmon (found during
this pass's own crate-migration sweep, in a different shape here: the bug
was in this crate's own tilde-expansion helper rather than a
dirs::xxx().unwrap_or_else() chain). Fixed via bread_utils::xdg::home_dir,
which resolves a real home directory before ever needing to fall back.

Builds and tests clean: 205 passed, 1 pre-existing network-dependent test
ignored, 0 failed.
This commit is contained in:
Breadway 2026-07-17 10:13:06 +08:00
parent 8a2936b8fd
commit 830e80622e
3 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
breadarr-shared/Cargo.toml
View file

@ -9,3 +9,5 @@ anyhow.workspace = true
toml.workspace = true
reqwest.workspace = true
chrono.workspace = true
# TODO(owner): switch to tag-pinned git dependency once bread-utils is merged and tagged, matching the bread-theme pattern
bread-utils = { path = "../../bread-ecosystem-fix-worktree/bread-utils" }