Breadway/breadbar
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Clear clippy 1.97 lints (dead App fields, from_geom self-convention)

Browse source 
Toolchain drift — pre-existing on main under clippy 0.1.97, both
mechanical: `#[allow(dead_code)]` on the four held-for-lifetime sys-grid
widget fields, and `#[allow(clippy::wrong_self_convention)]` on
`from_geom` (`from` is the source button, not a conversion).
This commit is contained in:
Breadway 2026-08-31 15:48:41 +08:00
parent 0aac9afcaa
commit a806ac08c1
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/bar/workspaces.rs
View file

@ -431,6 +431,9 @@ impl WorkspaceTrail {
self.inner.borrow_mut().tick = Some(id); self.inner.borrow_mut().tick = Some(id);
} }
// `from` is a noun here (the source button we animate away from), not a
// conversion — `&self` is correct.
#[allow(clippy::wrong_self_convention)]
fn from_geom(&self, from: Option<&gtk4::Button>, to: &gtk4::Button) -> Option<Geom> { fn from_geom(&self, from: Option<&gtk4::Button>, to: &gtk4::Button) -> Option<Geom> {
let st = self.inner.borrow(); let st = self.inner.borrow();
let live = if self.pill.is_visible() && st.geom.w > 0.5 { let live = if self.pill.is_visible() && st.geom.w > 0.5 {

6
src/main.rs
View file

@ -217,10 +217,16 @@ pub struct App {
// ── Stats bar ───────────────────────────────────────────────────────── // ── Stats bar ─────────────────────────────────────────────────────────
// Island chrome matches the Liquid Motion demo: volume / wifi / battery // Island chrome matches the Liquid Motion demo: volume / wifi / battery
// / hamburger. CPU/RAM/power live in the control panel, not on the bar. // / hamburger. CPU/RAM/power live in the control panel, not on the bar.
// Held to keep the control-panel sys-grid widgets alive for the App's
// lifetime; their parent boxes own them, so they're never read back.
#[allow(dead_code)]
system_stats_box: gtk4::Box, system_stats_box: gtk4::Box,
system_sep: gtk4::Separator, system_sep: gtk4::Separator,
#[allow(dead_code)]
cpu_pair: gtk4::Box, cpu_pair: gtk4::Box,
#[allow(dead_code)]
mem_pair: gtk4::Box, mem_pair: gtk4::Box,
#[allow(dead_code)]
pwr_pair: gtk4::Box, pwr_pair: gtk4::Box,
gpu_pair: gtk4::Box, gpu_pair: gtk4::Box,
cpu_lbl: gtk4::Label, cpu_lbl: gtk4::Label,