New Forgejo-origin issues bypass cycle project defaults #94

New issue

Closed

opened 2026-10-14 20:49:36 +08:00 by Breadway · 1 comment

Breadway commented

2026-10-14 20:49:36 +08:00

Owner

How found: independent PR90 review at 49f72305ba. Confidence: high, reproduced by signed issues/opened HMAC webhook. Repair in PR90 commit ecdc070: import_issue assigns cycle_id only for non-PR imports whose created_at and updated_at are both within 30 days, inheriting the unique open cycle project default and leaving ambiguous multi-cycle matches unassigned. Historical reconcile imports, PRs, and malformed timestamps stay unassigned, so no existing cards are retroactively reassigned. Regressions: signed webhook test now asserts the imported issue inherits the cycle; new reconcile test asserts inheritance for genuinely new external issues; existing suite case covers historical exclusion, PR exclusion, and ambiguous defaults. Authenticated sync regressions pass: sync 12/12, full workspace 26/26 plus clippy and check-docs. No separate PR created.

How found: independent PR90 review at 49f72305ba04e0694e472a03fc80949252921a59. Confidence: high, reproduced by signed issues/opened HMAC webhook. Repair in PR90 commit ecdc070: import_issue assigns cycle_id only for non-PR imports whose created_at and updated_at are both within 30 days, inheriting the unique open cycle project default and leaving ambiguous multi-cycle matches unassigned. Historical reconcile imports, PRs, and malformed timestamps stay unassigned, so no existing cards are retroactively reassigned. Regressions: signed webhook test now asserts the imported issue inherits the cycle; new reconcile test asserts inheritance for genuinely new external issues; existing suite case covers historical exclusion, PR exclusion, and ambiguous defaults. Authenticated sync regressions pass: sync 12/12, full workspace 26/26 plus clippy and check-docs. No separate PR created.

Breadway added the

bug

sync

labels

2026-10-14 20:49:37 +08:00

Breadway referenced this issue

2026-10-14 20:50:56 +08:00

Add project defaults to cycles #90

Breadway referenced this issue

2026-10-14 20:50:56 +08:00

Breadboard automatic cycle delegation based on repo #87

Breadway self-assigned this

2026-10-14 20:52:22 +08:00

Breadway commented

2026-10-15 13:02:56 +08:00

Author

Owner

BB-107 fix verified genuinely, merged with PR90. Old failure reproduced: new inheritance tests against 49f7230 code fail with cycle_id None vs Some(1) for new external imports. On ecdc070 both tests pass: signed webhook import inherits the unique default, reconcile import of a genuinely new external issue inherits, while historical imports, PRs, ambiguous multi-cycle matches, and malformed timestamps stay unassigned. Guards: non-PR only, both timestamps within 30 days, unique open match. Merge f02d977b1b. Full evidence in PR90 issuecomment-5083. Leaving status for coordinator verification; not marking done.

BB-107 fix verified genuinely, merged with PR90. Old failure reproduced: new inheritance tests against 49f7230 code fail with cycle_id None vs Some(1) for new external imports. On ecdc070 both tests pass: signed webhook import inherits the unique default, reconcile import of a genuinely new external issue inherits, while historical imports, PRs, ambiguous multi-cycle matches, and malformed timestamps stay unassigned. Guards: non-PR only, both timestamps within 30 days, unique open match. Merge f02d977b1b3e3502b1c97bac5071944330b38edb. Full evidence in PR90 issuecomment-5083. Leaving status for coordinator verification; not marking done.

Breadway closed this issue

2026-10-15 13:06:17 +08:00