Breadway/breadbox
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

fix: launcher overlay paints opaque @bg instead of transparent
All checks were successful
check / check (push) Successful in 3m36s
Details

Browse source 
The full-screen overlay window sets `window { background-color: transparent }`
in its app CSS (APPLICATION priority), but `bind_window_auto` re-broadcasts
the shared component sheet — which includes `window { background-color: @bg }`
— as a widget-tree provider at STYLE_PROVIDER_PRIORITY_USER - 10. Provider
priority is the primary cascade key, so that outranks the app rule regardless
of selector specificity: the "transparent overlay" fills the screen with an
opaque @bg (#0c0c0c) rectangle, hiding the whole desktop behind the launcher.
Guaranteed to bite under a VM's software renderer where there's no GL context
to paper over it.

Bind the app sheet too, via bind_window_auto_with_app_css (rides at USER - 9,
back above the shared window rule) — same pattern breadbar and breadhelp
already use. Verified with a headless pixman sway + solid-colour background:
the overlay region outside the panel now shows the desktop through.

breadsearch and breadclip use the same new_overlay_window + bind_window_auto
pattern and need the same fix.
This commit is contained in:
Breadway 2026-08-31 21:57:54 +08:00
parent 5169901b95
commit 96a752e61d
1 changed files with 18 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

22
breadbox/src/main.rs
View file

@ -236,9 +236,8 @@ fn run_ui(
let shell_theme = theme::shell_theme();
let launcher = shell_theme.launcher().clone();
// Shared ecosystem base (fonts, palette, generic widgets) first, then
// breadbox-specific CSS layered on top — both hot-reload on
// `bread-theme reload` (the closure re-reads the pywal palette).
// Shared ecosystem base (fonts, palette, generic widgets) as a
// display-level fallback; the real per-window sheet is bound below.
bread_theme::gtk::apply_shared();
{
let launcher = launcher.clone();
@ -255,7 +254,22 @@ fn run_ui(
// Full-screen transparent overlay; panel widget is positioned inside it.
let window = bread_utils::gtk_popup::new_overlay_window(app, "breadbox");
bread_theme::gtk::bind_window_auto(&window);
// Bind the *app* sheet — not just the shared one — as the widget-tree
// provider. `bind_window_auto` alone re-broadcasts the shared
// component sheet (which includes `window { background-color: @bg }`)
// at USER-10, outranking our APPLICATION-priority
// `window { background-color: transparent }` regardless of specificity
// — so the "transparent overlay" paints solid @bg and the launcher
// covers the screen in an opaque black rectangle (worse under a VM's
// software renderer, where there's no GL to mask it). `_with_app_css`
// rides our sheet at USER-9, back on top.
{
let launcher = launcher.clone();
let tokens = shell_theme.tokens().clone();
bread_theme::gtk::bind_window_auto_with_app_css(&window, move |p| {
build_css(p, &launcher, &tokens)
});
}
let close_all: Rc<dyn Fn()> = Rc::new({
let w = window.clone();