Breadway/breadclip
1
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Workspace cargo fmt --check fails on existing formatting drift #21

New issue
Open
opened 2026-10-18 22:20:45 +08:00 by Breadway · 1 comment
Breadway commented 2026-10-18 22:20:45 +08:00
Owner
Copy link

Found during independent PR19 review at a55d015f0c with rustfmt 1.9.0-stable (8bab26f4f6), rustc 1.97.1. Confidence: confirmed command failure. In a clean detached clone, cargo fmt --check exits 1 with differences in breadclip/src/main.rs:4-12,27-28,369,555,610; breadclip/src/screenshot.rs:80; breadclip-core/src/config.rs:85-94,135; breadclip-core/src/lib.rs:81,288,479 onward; breadclipd/src/ignore_rules.rs:101,124; breadclipd/src/main.rs:473 onward. These are pre-existing formatting differences, not introduced by the tag pin. Existing check.yml gates clippy/test but not formatting. Normalize formatting under the supported toolchain and verify cargo fmt --check exits 0; do not claim the PR19 requested formatting criterion passed until it does. Full output retained in review shell sh_14f6056b9001O0QqWCxFwwEQ0N.

Found during independent PR19 review at a55d015f0cdf1b6e1736a4432de628f516d8fac2 with rustfmt 1.9.0-stable (8bab26f4f6), rustc 1.97.1. Confidence: confirmed command failure. In a clean detached clone, cargo fmt --check exits 1 with differences in breadclip/src/main.rs:4-12,27-28,369,555,610; breadclip/src/screenshot.rs:80; breadclip-core/src/config.rs:85-94,135; breadclip-core/src/lib.rs:81,288,479 onward; breadclipd/src/ignore_rules.rs:101,124; breadclipd/src/main.rs:473 onward. These are pre-existing formatting differences, not introduced by the tag pin. Existing check.yml gates clippy/test but not formatting. Normalize formatting under the supported toolchain and verify cargo fmt --check exits 0; do not claim the PR19 requested formatting criterion passed until it does. Full output retained in review shell sh_14f6056b9001O0QqWCxFwwEQ0N.
Breadway commented 2026-10-20 15:34:04 +08:00
Author
Owner
Copy link

Already fixed on origin/main. No code change, no PR opened.

Evidence (fresh worktree at origin/main 7d1d3bc, rustfmt 1.9.0-stable 8bab26f4f6):

  • Commit fb82707 "style: restore workspace rustfmt formatting" (Oct 18 2026) is an ancestor of origin/main. It touches exactly the five files this card lists (breadclip-core/src/config.rs, breadclip-core/src/lib.rs, breadclip/src/main.rs, breadclip/src/screenshot.rs, breadclipd/src/ignore_rules.rs).
  • cargo fmt --check on origin/main: exit 0, zero diffs.
  • cargo clippy --all-targets -- -D warnings: exit 0 (all five workspace crates checked).
  • cargo test: exit 0. breadclip-core 19 passed, breadclipd 32 passed, tests/privacy_regression 2 passed, breadclip 0 tests. 53 passed, 0 failed.

The card's drift predates fb82707 (card filed 2026-10-18 14:20 UTC, drift referenced PR19 review at a55d015). Leaving at todo for the board owner to close; I did not mark it done.

Already fixed on origin/main. No code change, no PR opened. Evidence (fresh worktree at origin/main 7d1d3bc, rustfmt 1.9.0-stable 8bab26f4f6): - Commit fb82707 "style: restore workspace rustfmt formatting" (Oct 18 2026) is an ancestor of origin/main. It touches exactly the five files this card lists (breadclip-core/src/config.rs, breadclip-core/src/lib.rs, breadclip/src/main.rs, breadclip/src/screenshot.rs, breadclipd/src/ignore_rules.rs). - cargo fmt --check on origin/main: exit 0, zero diffs. - cargo clippy --all-targets -- -D warnings: exit 0 (all five workspace crates checked). - cargo test: exit 0. breadclip-core 19 passed, breadclipd 32 passed, tests/privacy_regression 2 passed, breadclip 0 tests. 53 passed, 0 failed. The card's drift predates fb82707 (card filed 2026-10-18 14:20 UTC, drift referenced PR19 review at a55d015). Leaving at todo for the board owner to close; I did not mark it done.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/eco-83-check-checkout-isolation
feature/breadbug-pilot
fix/clip-17-rc-cache-cleanup
v0.3.0
v0.3.0-rc.1
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.1
v0.1.0
Labels
Clear labels   
ci

   
enhancement
No labels
ci
enhancement
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Breadway/breadclip#21
No description provided.