CI: isolate beta and stable index generation clones #20

Closed
opened 2026-09-30 02:07:24 +08:00 by Breadway · 2 comments
Owner

The release workflows still clean a runner-wide shared path before cloning bread-ecosystem. In rc-release.yml the rm -rf /tmp/bread-ecosystem-ci-* glob can delete another concurrent job's mktemp clone. In release.yml the fixed /tmp/bread-ecosystem-ci path has the same collision risk. Give each invocation its own mktemp directory and clean only that directory. Keep the change limited to these workflows.

The release workflows still clean a runner-wide shared path before cloning bread-ecosystem. In rc-release.yml the `rm -rf /tmp/bread-ecosystem-ci-*` glob can delete another concurrent job's mktemp clone. In release.yml the fixed `/tmp/bread-ecosystem-ci` path has the same collision risk. Give each invocation its own mktemp directory and clean only that directory. Keep the change limited to these workflows.
Author
Owner

Implemented in breadcrumbs PR #21. The beta and stable workflows now clone into job-unique mktemp directories and remove only their own clones. YAML parsing, shell syntax, and diff checks pass.

Implemented in [breadcrumbs PR #21](https://git.breadway.dev/Breadway/breadcrumbs/pulls/21). The beta and stable workflows now clone into job-unique mktemp directories and remove only their own clones. YAML parsing, shell syntax, and diff checks pass.
Author
Owner

Review: implementation matches the requested scope. Acceptance criteria: (1) beta clone must use a job-unique temporary directory and avoid deleting other jobs' directories, satisfied by .forgejo/workflows/rc-release.yml:54-57; (2) stable clone must use a job-unique temporary directory and clean only its own clone, satisfied by .forgejo/workflows/release.yml:58-61. No unrelated workflow files changed. I found no code changes to request. PR #21 is mergeable, but its check / check (push) CI status is still pending, so this is not a merge approval yet. I am leaving the issue in REVIEW pending CI.

Review: implementation matches the requested scope. Acceptance criteria: (1) beta clone must use a job-unique temporary directory and avoid deleting other jobs' directories, satisfied by `.forgejo/workflows/rc-release.yml:54-57`; (2) stable clone must use a job-unique temporary directory and clean only its own clone, satisfied by `.forgejo/workflows/release.yml:58-61`. No unrelated workflow files changed. I found no code changes to request. PR #21 is mergeable, but its `check / check (push)` CI status is still pending, so this is not a merge approval yet. I am leaving the issue in REVIEW pending CI.
Sign in to join this conversation.
No labels
bug
ci
enhancement
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Breadway/breadcrumbs#20
No description provided.