clearing hidden=false never propagates to the NM profile #28

Open
opened 2026-10-15 11:11:22 +08:00 by Breadway · 0 comments
Owner

Found: full codebase audit 2026-10-15, by reading src/nm.rs connect_verbose.
Confidence: high.
Location: src/nm.rs:940.

needs_update = password.is_some() || net.hidden || eap.is_some(). net.hidden is a bool, so un-hiding a network (hidden true to false, no password change) yields needs_update false and updated_settings_for never runs. The NM profile keeps hidden=true forever because later connects carry no password either.

Suggested fix: trigger the profile update when the hidden flag differs from the saved profile, not on its absolute value.

Found: full codebase audit 2026-10-15, by reading src/nm.rs connect_verbose. Confidence: high. Location: src/nm.rs:940. needs_update = password.is_some() || net.hidden || eap.is_some(). net.hidden is a bool, so un-hiding a network (hidden true to false, no password change) yields needs_update false and updated_settings_for never runs. The NM profile keeps hidden=true forever because later connects carry no password either. Suggested fix: trigger the profile update when the hidden flag differs from the saved profile, not on its absolute value.
Sign in to join this conversation.
No labels
bug
ci
enhancement
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Breadway/breadcrumbs#28
No description provided.