DNS pin does not create missing ipv6 section, leaking auto DNS on v6 #32

Open
opened 2026-10-15 11:11:25 +08:00 by Breadway · 0 comments
Owner

Found: full codebase audit 2026-10-15, by reading src/nm.rs enforce_dns and apply_dns.
Confidence: medium (depends on profiles lacking an ipv6 section).
Location: src/nm.rs:856-860.

ipv4 uses entry().or_default() but ipv6 only applies if the section already exists. On profiles without ipv6, the pin sets ignore-auto-dns on v4 only and v6 keeps DHCP DNS around the pin.

Suggested fix: create the ipv6 section the same way as ipv4.

Found: full codebase audit 2026-10-15, by reading src/nm.rs enforce_dns and apply_dns. Confidence: medium (depends on profiles lacking an ipv6 section). Location: src/nm.rs:856-860. ipv4 uses entry().or_default() but ipv6 only applies if the section already exists. On profiles without ipv6, the pin sets ignore-auto-dns on v4 only and v6 keeps DHCP DNS around the pin. Suggested fix: create the ipv6 section the same way as ipv4.
Sign in to join this conversation.
No labels
bug
ci
enhancement
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Breadway/breadcrumbs#32
No description provided.