portal detection misses non-standard portal status codes #36
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found: full codebase audit 2026-10-15, by reading src/status.rs is_portal_status.
Confidence: medium.
Location: src/status.rs:66-68.
Only 200/301/302/303/307/308/511 count as portal. A portal answering 404/403 with a login page plus blocked ping classifies DownNoNet, so the watcher reconnects pointlessly instead of telling the user to sign in.
Suggested fix: broaden portal-shaped codes (any non-204 2xx/3xx) or treat unexpected bodies as portal candidates.