Breadway/breadhelp
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Troubleshoot wizard ignores Fix::requires_confirm, runs fixes unconditionally #1

New issue
Open
opened 2026-08-06 08:55:34 +08:00 by Breadway · 0 comments
Breadway commented 2026-08-06 08:55:34 +08:00
Owner
Copy link

Fix::requires_confirm (src/content/troubleshoot.rs) is a safety flag on content-authored fixes, meant to gate a confirmation step before the fix command is actually run. src/ui/troubleshoot_wizard.rs's "Run fix" button currently ignores it entirely and executes the fix command unconditionally regardless of the flag's value.

Found while doing a clippy pass across the ecosystem on 2026-08-06 — clippy flagged requires_confirm as an unread (dead_code) field, which is what surfaced that the UI never actually checks it. Left the field in place (it's real, hand-authored content) rather than deleting it, since the fix is a real feature gap: add a confirmation dialog in troubleshoot_wizard.rs that gates command execution when requires_confirm is true, rather than removing the flag.

`Fix::requires_confirm` (`src/content/troubleshoot.rs`) is a safety flag on content-authored fixes, meant to gate a confirmation step before the fix command is actually run. `src/ui/troubleshoot_wizard.rs`'s "Run fix" button currently ignores it entirely and executes the fix command unconditionally regardless of the flag's value. Found while doing a clippy pass across the ecosystem on 2026-08-06 — clippy flagged `requires_confirm` as an unread (dead_code) field, which is what surfaced that the UI never actually checks it. Left the field in place (it's real, hand-authored content) rather than deleting it, since the fix is a real feature gap: add a confirmation dialog in `troubleshoot_wizard.rs` that gates command execution when `requires_confirm` is true, rather than removing the flag.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Breadway/breadhelp#1
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?