Reject failed hyprctl eval processes and retain stderr diagnostics during DPMS apply #16
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found during independent exact-head review of MON-14 / PR15 at
056f0b0b29. Confidence: high, independently reproduced with a fake executable, not the live compositor. src/monitor.rs:392-401 checks stdout only and ignores output.status and stderr. A fake hyprctl returning stdout ok with exit 7 yields Ok(()); a stderr-only refusal loses its diagnostic. Harness imports the immutable monitor.rs module and calls apply_monitors with one enabled DP-1 whose dpms=false. Repair on existing PR15: require successful exit plus exact trimmed ok reply, report stderr/status, add process-level regression tests. Related MON-14. Runtime DPMS behavior still requires isolated hidden headless Hyprland evidence.Independent exact-head re-review: PASS at
543629730c(PR Breadway/breadmon#15). Failed-process defect repaired: hyprctl_eval requires exit 0 AND trimmed stdout exactly ok, errors carry exit status/stdout/stderr, and main.rs reports Apply failed without saving config on error. Six process-level regression tests plus 12 clean 16-thread stress runs. Full evidence: #15 (comment) . Merged42e11c6b21. Moved to review awaiting coordinator verification, not done.Same merged PR15 verification as MON-14.