breadman: watch bread-theme's palette cache instead of ~/.cache/wal #8
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
breadman/src/theme.rs:33adds~/.cache/walto its watched dirs. After epic PYWAL moves the global palette to a bread-owned path, breadman would stop recolouring on wallpaper change.breadman/ui/src/app.css,breadpad-shared/src/theme.rs,breadpad/src/main.rs.Part of epic PYWAL.
PR: #9
breadman now watches bread_theme::palette_cache_dir() instead of a hardcoded ~/.cache/wal. Bumping bread-theme also required passing Typography::default() into the now-two-arg stylesheet() call in breadpad-shared. bread-theme dep points at feature/native-palette for now (needs the release tag before merge). Verified check/clippy/test (workspace) against a temporary local override of the in-progress bread-theme worktree, then reverted the override.
Reviewed breadpad#9: approve pending the bread-theme release. The code is correct (watcher now on
palette_cache_dir(), stylesheet&Typographycall site updated). CI is red only because Cargo.lock does not match the branch dep; reproduced in a clean clone with--locked. After bread-ecosystem#36 is released, re-point both Cargo.toml files to the tag and commit the regenerated lock. Nits in the PR comment:Typography::default()vsactive(), and the watcher skipping a not-yet-existing cache dir. Left in review.Pushed nit fixes to feature/drop-pywal: watched_dirs() now creates palette_cache_dir() before the retain(exists) filter so a fresh install's first breadpaper write is seen, and breadpad-shared's build_css() now uses Typography::active() instead of Typography::default() to follow the shell theme's font tokens. Also refreshed Cargo.lock against bread-theme's latest feature/native-palette commit (3758f0c), verified with a fresh-clone cargo build --workspace --locked.
Verified: cargo check --workspace, cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace, all clean.
PR: #9
Second-round review: the code is correct and CI is green. The watcher now creates the cache dir, and
Typography::active()is right. One doc fix is left, plus the relock. Full review: #9README.md:82says "Falls back to Catppuccin Mocha". That is false: bread-theme falls back to a legacy wal colors.json, then its built-in bread-toned default. This is the same fix breadbar#25 needed.breadman/Cargo.toml:33andbreadpad-shared/Cargo.toml:10to the release tag and commit the regenerated Cargo.lock.Rework happens on the existing branch feature/drop-pywal, and PR #9 stays open. Do not open a second PR for this key.
Round-3 update, PR: #9
README.md:82 fixed (falls back to a legacy wal colors.json cache if present, then bread-theme's own built-in bread-toned default, not Catppuccin Mocha). Relocked Cargo.lock against bread-theme's latest feature/native-palette commit. Confirmed neither breadman nor breadpad-shared enables bread-theme's new extract feature and nothing calls palette_from_image/pywal_colors/generate_output, so this crate stays extraction-free as intended (do NOT enable, per instructions).
Verified: cargo build --workspace --locked, cargo test --workspace --locked (all passed), cargo clippy --workspace --all-targets --locked -- -D warnings, matching this repo's actual CI gate.
Third-round review of PR #9: approved, pending the bread-theme tag (#9 (comment)). Before merging, two steps are needed. First, rebase onto main: the Typography conflict in breadpad-shared/src/theme.rs resolves to main's side both times. Second, repin both bread-theme deps from the branch to the new tag and relock, since lint-pins rejects branch pins. The issue stays in review.