Breadway/bos-settings
1
0
Fork 0
Code Issues 3 Pull requests 2 Projects Releases Packages Wiki Activity Actions

Gate cargo fmt --check in CI #12

Merged
Breadway merged 2 commits from fix/eco-21-fmt-gate-bos-settings into main 2026-09-11 18:46:27 +08:00
Conversation 0 Commits 2 Files changed 15 +430 -97
Breadway commented 2026-09-11 17:50:46 +08:00
Owner
Copy link

Normalises the tree with a dedicated cargo fmt --all commit, adds that commit's SHA to a new .git-blame-ignore-revs, and adds a cargo fmt --all -- --check step to check.yml (the step check.yml's own comment said was pending until the tree was normalised).

Two commits: formatting only, then the CI/blame-ignore change, so the reformat is easy to skip when reading blame or reviewing history.

Verified locally (stubbing frontend/build the way CI does): cargo fmt --all -- --check, cargo clippy --all-targets --locked -- -D warnings, and cargo test --locked, all clean.

Part of ECO-21 (bos-settings half; bread-ecosystem gets its own PR).

Normalises the tree with a dedicated `cargo fmt --all` commit, adds that commit's SHA to a new `.git-blame-ignore-revs`, and adds a `cargo fmt --all -- --check` step to `check.yml` (the step check.yml's own comment said was pending until the tree was normalised). Two commits: formatting only, then the CI/blame-ignore change, so the reformat is easy to skip when reading blame or reviewing history. Verified locally (stubbing `frontend/build` the way CI does): `cargo fmt --all -- --check`, `cargo clippy --all-targets --locked -- -D warnings`, and `cargo test --locked`, all clean. Part of ECO-21 (bos-settings half; bread-ecosystem gets its own PR).
Normalises the tree ahead of gating cargo fmt --check in CI.
Formatting only, no behavior change.
ci: gate cargo fmt --check in check.yml
All checks were successful
check / check (push) Successful in 3m0s
Details
cd1a181dc8 
Adds the fmt commit's SHA to .git-blame-ignore-revs and enables the
fmt step check.yml's own comment said was pending until the tree was
normalised.
Breadway deleted branch fix/eco-21-fmt-gate-bos-settings 2026-09-11 18:46:27 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breadbug

   
bug

   
displays

   
enhancement

   
keybinds

   
network

   
phase-1

   
power

   
privacy

   
recovery

   
search

   
snapshots

   
sound

   
ui

   
ux
No labels
breadbug
bug
displays
enhancement
keybinds
network
phase-1
power
privacy
recovery
search
snapshots
sound
ui
ux
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Breadway/bos-settings!12
No description provided.