Breadway/bos-site
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Document the safer logout shortcut #1

Closed
Breadway wants to merge 0 commits from fix/bos-42-site-exit-binding into main
pull from: fix/bos-42-site-exit-binding
merge into: Breadway:main
Conversation 3 Commits - Files changed -
Breadway commented 2026-09-30 18:51:57 +08:00
Owner
Copy link

The website still lists Super+N as logout after BOS PR #60 moved exit to Super+Shift+Escape. Split the lock and logout rows and document the current shortcut.

This first site PR imports the clean static source from local commit 0b921ba as commit 611d55d. The following commit 265c908 contains the focused shortcut correction and changelog entry. The original checkout and production website are untouched.

Verified the current BOS main exit binding, parsed the HTML shortcut row, ran bash -n deploy.sh and git diff --check. No build step or CI exists for this static site.

Completes the website portion of BOS-42; the BOS source portion is already merged.

The website still lists Super+N as logout after BOS PR #60 moved exit to Super+Shift+Escape. Split the lock and logout rows and document the current shortcut. This first site PR imports the clean static source from local commit 0b921ba as commit 611d55d. The following commit 265c908 contains the focused shortcut correction and changelog entry. The original checkout and production website are untouched. Verified the current BOS main exit binding, parsed the HTML shortcut row, ran bash -n deploy.sh and git diff --check. No build step or CI exists for this static site. Completes the website portion of BOS-42; the BOS source portion is already merged.
Import the clean site source at 0b921ba without changing the live deployment.
Breadway commented 2026-09-30 23:49:19 +08:00
Author
Owner
Copy link

Independent review PASS at 265c90802b. Verified focused logout change against merged BOS main, parsed HTML lock/logout rows, deploy script shell syntax, and git diff --check. Source import is isolated from the focused correction. No CI configured; no deployment or desktop interaction performed.

Independent review PASS at 265c90802bf3359d65a6b3dc227b6c2c77ef0ef4. Verified focused logout change against merged BOS main, parsed HTML lock/logout rows, deploy script shell syntax, and git diff --check. Source import is isolated from the focused correction. No CI configured; no deployment or desktop interaction performed.
Breadway commented 2026-10-01 15:32:48 +08:00
Author
Owner
Copy link

Review finding

  • deploy.sh:12 hardcodes the private overlay IP as the default HESTIA_HOST for this public repository. Remove the concrete internal address and require the deploy operator to supply the destination explicitly. Also remove the internal edge-route detail from the preceding comment at deploy.sh:4-6.

PR #1 imports the correct static source for bos.breadway.dev, and PR #4's pinned-build copy is accurate. Keep PR #1 open for this change and keep stacked PR #4 open. Do not open a second PR for BOS-37.

## Review finding - [ ] `deploy.sh:12` hardcodes the private overlay IP as the default `HESTIA_HOST` for this public repository. Remove the concrete internal address and require the deploy operator to supply the destination explicitly. Also remove the internal edge-route detail from the preceding comment at `deploy.sh:4-6`. PR #1 imports the correct static source for `bos.breadway.dev`, and PR #4's pinned-build copy is accurate. Keep PR #1 open for this change and keep stacked PR #4 open. Do not open a second PR for BOS-37.
Breadway commented 2026-10-01 15:45:50 +08:00
Author
Owner
Copy link

Review rework pushed to the existing PR #1 branch fix/bos-42-site-exit-binding at 9b977d0142a2e7aab836cf2180a7e36d7539ea59. Removed the private overlay IP default and internal routing details from deploy.sh, made HESTIA_HOST required, and removed private topology details from the public README. PR #4 remains stacked on this branch. Verified bash -n deploy.sh, that an unset HESTIA_HOST exits with the expected message, a README/deploy script scan for private route details, and git diff --check. No deployment was run.

Review rework pushed to the existing PR #1 branch `fix/bos-42-site-exit-binding` at `9b977d0142a2e7aab836cf2180a7e36d7539ea59`. Removed the private overlay IP default and internal routing details from `deploy.sh`, made `HESTIA_HOST` required, and removed private topology details from the public README. PR #4 remains stacked on this branch. Verified `bash -n deploy.sh`, that an unset `HESTIA_HOST` exits with the expected message, a README/deploy script scan for private route details, and `git diff --check`. No deployment was run.
Breadway closed this pull request 2026-10-02 17:55:57 +08:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Breadway/bos-site!1
No description provided.