Breadway/bread-ecosystem
1
0
Fork 0
Code Issues 1 Pull requests 4 Projects Releases Packages Wiki Activity Actions

shell themes: bring chip_height and dot_widths up to the approved reference

Browse source 
breadbar had to hardcode past these: the manifests carried pre-review values
(chip_height 32/20/36, dot_widths [6,10,14,18]) that disagreed with what the
bar actually draws, so a chrome pass overrode them locally rather than let the
manifest dictate wrong geometry.

Updated to what the user approved on the interactive reference in
bos-ui-demos/proposed/: one chip highlight height per bar (26 island, 22 flush,
22 capsule) and Option-B dot widths [8,13,17,22]. Two tests pinned the old
numbers and are updated with the reason.

A manifest that states one thing while the app draws another is the defect
class this project has hit repeatedly; the local hardcodes in breadbar can now
be removed in favour of these.
This commit is contained in:
Breadway 2026-08-26 09:39:38 +08:00
parent 3a22b62694
commit 5b5b17fdf4
4 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
bread-theme/src/shell/mod.rs
View file

@ -530,7 +530,9 @@ mod tests {
assert!(matches!(w.keyboard, Keyboard::None));
assert_eq!(w.layer, "top");
assert_eq!(theme.tokens().chip_height(), 32);
// 26, not breadbar's historical 32: the user approved a single 26px chip
// highlight height on the interactive reference (bos-ui-demos/proposed/).
assert_eq!(theme.tokens().chip_height(), 26);
assert_eq!(theme.tokens().icon_px(), 24);
}
@ -905,7 +907,7 @@ mod tests {
fn spotlight_workspaces_are_dots_with_the_demos_own_widths() {
let theme = load_named(builtin::SPOTLIGHT_ID).expect("spotlight should resolve");
assert!(matches!(theme.modules().workspaces.style, WorkspaceStyle::Dots));
assert_eq!(theme.modules().workspaces.dot_widths, [6, 10, 14, 18]);
assert_eq!(theme.modules().workspaces.dot_widths, [8, 13, 17, 22]);
}
#[test]