Remove em dashes from code and docs #20

Merged
Breadway merged 2 commits from fix/em-dash-cleanup into main 2026-09-09 14:13:10 +08:00
Owner

Removes em dashes across the repo (comments, doc comments, Markdown docs, CI workflow comments, TOML comments), replacing each with whatever reads most naturally in context: colon, semicolon, comma, or parentheses.

No intentional em-dash placeholders exist in this repo (unlike some sibling repos that use "—" as a literal "no value" UI glyph), so this is a full removal with no exceptions.

Also regenerated the README's Products table (scripts/gen-readme-products.sh) after fixing the em dash baked into the notes-append separator and the breadcast/breadarr registry descriptions.

Removes em dashes across the repo (comments, doc comments, Markdown docs, CI workflow comments, TOML comments), replacing each with whatever reads most naturally in context: colon, semicolon, comma, or parentheses. No intentional em-dash placeholders exist in this repo (unlike some sibling repos that use `"—"` as a literal "no value" UI glyph), so this is a full removal with no exceptions. Also regenerated the README's Products table (`scripts/gen-readme-products.sh`) after fixing the em dash baked into the notes-append separator and the `breadcast`/`breadarr` registry descriptions.
Author
Owner

Reviewed. Held for you to land: bread-ecosystem is on the release train, so this is a recommendation only, not a merge.

Acceptance criteria (my read): remove every em dash across the repo (comments, doc comments, Markdown, CI/TOML comments), replacing each with natural punctuation; the PR body states this is a full removal with no exceptions; no functional changes; regenerate the README Products table.

Assessment:

  • The edits that are present are punctuation-only in comments and string literals (bread-theme, bread-utils, docs, scripts). No logic changes. No new em dashes on added lines. Commit message is clean.
  • Branch merges cleanly into main.

Do not merge yet, the cleanup is incomplete. The PR claims no exceptions, but these tracked files still contain em dashes in comments and were not touched:

  • .gitignore (lines 3 and 9)
  • ci/Containerfile (line 11)
  • packaging/arch/PKGBUILD (line 4)
  • bread-polkit/contrib/hyprland.conf (line 1)

Finish those on the same branch fix/em-dash-cleanup, keep PR #20 open, no new PR. Also no CI run exists for the head commit, so trigger check and confirm green before merging.

Leaving in review.

Reviewed. Held for you to land: `bread-ecosystem` is on the release train, so this is a recommendation only, not a merge. Acceptance criteria (my read): remove every em dash across the repo (comments, doc comments, Markdown, CI/TOML comments), replacing each with natural punctuation; the PR body states this is a full removal with no exceptions; no functional changes; regenerate the README Products table. Assessment: - The edits that are present are punctuation-only in comments and string literals (bread-theme, bread-utils, docs, scripts). No logic changes. No new em dashes on added lines. Commit message is clean. - Branch merges cleanly into `main`. Do not merge yet, the cleanup is incomplete. The PR claims no exceptions, but these tracked files still contain em dashes in comments and were not touched: - `.gitignore` (lines 3 and 9) - `ci/Containerfile` (line 11) - `packaging/arch/PKGBUILD` (line 4) - `bread-polkit/contrib/hyprland.conf` (line 1) Finish those on the same branch `fix/em-dash-cleanup`, keep PR #20 open, no new PR. Also no CI run exists for the head commit, so trigger `check` and confirm green before merging. Leaving in review.
docs: remove em dashes from dotfiles and packaging comments
All checks were successful
check / check (push) Successful in 2m10s
9aef739379
Follow-up to the em-dash cleanup: .gitignore, ci/Containerfile,
packaging/arch/PKGBUILD, and bread-polkit/contrib/hyprland.conf still
had em dashes in their header comments. Replaced with a colon or comma
to match the rest of the pass.
Author
Owner

Follow-up commit pushed to fix/em-dash-cleanup (9aef739), PR #20 updated, still open.

Fixed the four remaining files flagged in review: .gitignore (lines 3, 9), ci/Containerfile (line 11), packaging/arch/PKGBUILD (line 4), bread-polkit/contrib/hyprland.conf (line 1). Each em dash replaced with a colon, except the Containerfile "otherwise" clause which reads better as a comma.

Repo-wide rescan of all tracked files: no em dashes remain. The only en dashes left are numeric ranges (color1-6, font-weight 100-900, 0.0-1.0, 8-12px) which are correct range notation, not prose, so left as is. No merge performed (release-sensitive repo).

Follow-up commit pushed to `fix/em-dash-cleanup` (9aef739), PR #20 updated, still open. Fixed the four remaining files flagged in review: `.gitignore` (lines 3, 9), `ci/Containerfile` (line 11), `packaging/arch/PKGBUILD` (line 4), `bread-polkit/contrib/hyprland.conf` (line 1). Each em dash replaced with a colon, except the Containerfile "otherwise" clause which reads better as a comma. Repo-wide rescan of all tracked files: no em dashes remain. The only en dashes left are numeric ranges (color1-6, font-weight 100-900, 0.0-1.0, 8-12px) which are correct range notation, not prose, so left as is. No merge performed (release-sensitive repo).
Author
Owner

Reviewed PR #20 (head 9aef739). Looks ready to merge, holding for you because bread-ecosystem is on the release train.

What it does: removes em dashes across bread-theme and bread-utils source comments and doc comments, docs/release-channels.md, docs/shell-themes.md, the scripts/*.sh helpers, ci/Containerfile, ci/build.sh, packaging/arch/PKGBUILD, registry/bread-ecosystem.toml, and .gitignore. The README Products table was regenerated via scripts/gen-readme-products.sh after fixing the em dash baked into the notes separator and the breadcast/breadarr registry descriptions. Balanced in-place edits (846/843), no functional changes.

Verified repo-wide: git grep -nP "\x{2014}" on the head commit returns nothing, so the four files flagged in earlier review are now clean and there are no remaining em dashes anywhere in the repo.

CI green (check: 2m10s), mergeable with no conflicts. Leaving in review for you to land.

Reviewed PR #20 (head `9aef739`). Looks ready to merge, holding for you because bread-ecosystem is on the release train. What it does: removes em dashes across bread-theme and bread-utils source comments and doc comments, `docs/release-channels.md`, `docs/shell-themes.md`, the `scripts/*.sh` helpers, `ci/Containerfile`, `ci/build.sh`, `packaging/arch/PKGBUILD`, `registry/bread-ecosystem.toml`, and `.gitignore`. The README Products table was regenerated via `scripts/gen-readme-products.sh` after fixing the em dash baked into the notes separator and the breadcast/breadarr registry descriptions. Balanced in-place edits (846/843), no functional changes. Verified repo-wide: `git grep -nP "\x{2014}"` on the head commit returns nothing, so the four files flagged in earlier review are now clean and there are no remaining em dashes anywhere in the repo. CI green (check: 2m10s), mergeable with no conflicts. Leaving in review for you to land.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Breadway/bread-ecosystem!20
No description provided.