Remove em dashes from code and docs #20
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/em-dash-cleanup"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Removes em dashes across the repo (comments, doc comments, Markdown docs, CI workflow comments, TOML comments), replacing each with whatever reads most naturally in context: colon, semicolon, comma, or parentheses.
No intentional em-dash placeholders exist in this repo (unlike some sibling repos that use
"—"as a literal "no value" UI glyph), so this is a full removal with no exceptions.Also regenerated the README's Products table (
scripts/gen-readme-products.sh) after fixing the em dash baked into the notes-append separator and thebreadcast/breadarrregistry descriptions.Reviewed. Held for you to land:
bread-ecosystemis on the release train, so this is a recommendation only, not a merge.Acceptance criteria (my read): remove every em dash across the repo (comments, doc comments, Markdown, CI/TOML comments), replacing each with natural punctuation; the PR body states this is a full removal with no exceptions; no functional changes; regenerate the README Products table.
Assessment:
main.Do not merge yet, the cleanup is incomplete. The PR claims no exceptions, but these tracked files still contain em dashes in comments and were not touched:
.gitignore(lines 3 and 9)ci/Containerfile(line 11)packaging/arch/PKGBUILD(line 4)bread-polkit/contrib/hyprland.conf(line 1)Finish those on the same branch
fix/em-dash-cleanup, keep PR #20 open, no new PR. Also no CI run exists for the head commit, so triggercheckand confirm green before merging.Leaving in review.
Follow-up commit pushed to
fix/em-dash-cleanup(9aef739), PR #20 updated, still open.Fixed the four remaining files flagged in review:
.gitignore(lines 3, 9),ci/Containerfile(line 11),packaging/arch/PKGBUILD(line 4),bread-polkit/contrib/hyprland.conf(line 1). Each em dash replaced with a colon, except the Containerfile "otherwise" clause which reads better as a comma.Repo-wide rescan of all tracked files: no em dashes remain. The only en dashes left are numeric ranges (color1-6, font-weight 100-900, 0.0-1.0, 8-12px) which are correct range notation, not prose, so left as is. No merge performed (release-sensitive repo).
Reviewed PR #20 (head
9aef739). Looks ready to merge, holding for you because bread-ecosystem is on the release train.What it does: removes em dashes across bread-theme and bread-utils source comments and doc comments,
docs/release-channels.md,docs/shell-themes.md, thescripts/*.shhelpers,ci/Containerfile,ci/build.sh,packaging/arch/PKGBUILD,registry/bread-ecosystem.toml, and.gitignore. The README Products table was regenerated viascripts/gen-readme-products.shafter fixing the em dash baked into the notes separator and the breadcast/breadarr registry descriptions. Balanced in-place edits (846/843), no functional changes.Verified repo-wide:
git grep -nP "\x{2014}"on the head commit returns nothing, so the four files flagged in earlier review are now clean and there are no remaining em dashes anywhere in the repo.CI green (check: 2m10s), mergeable with no conflicts. Leaving in review for you to land.