Register ram in the known-apps registry #35
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/ram-17-register-ram"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Adds
ramtoKNOWN_APPSinbread-shared/src/apps.rs, sobread.ram.*events andbread.command.ram.*commands are accepted on the bus instead of rejected as an unknown app. This is the one change the bread repo needs for the breadram integration (breadboard RAM-17); the event catalog and the command handling live in the breadram repo.The existing recognition test now asserts
ramalongside the other ids.Verified:
cargo fmt -p bread-shared,cargo clippy -p bread-shared --all-targets --locked -- -D warnings, andcargo test -p bread-shared --lib --locked(the apps suite, 15 tests) all pass.Part of RAM-17.
Independent exact-head review: PASS at
bc3b608f41. Base main7428366e71. Complete actual PR diff: one file, +2/-1; all file pages and PR pages exhausted, unique branch/card link.Criteria: ram registration and recognition test PASS (bread-shared/src/apps.rs:12-15,139-145); event and command namespace acceptance PASS (apps.rs:65-82,115-123, IPC integration breadd/src/ipc/mod.rs:310-370). Independent cargo test -p bread-shared --lib --locked: 67 passed, including 15 apps tests. cargo fmt -p bread-shared --check passed. A separate rustc probe importing the immutable apps.rs accepted bread.ram.pressure and bread.command.ram.{status,mode,action}, rejected other app namespaces, malformed ram commands and unknown targets. No unrelated churn. This accepts the bread-side registration only, not a claim of RAM-17 end-to-end deployed integration.
Required check: check / check (push), exact SHA above, success, Actions run 122 job 0. Read check.yml: workspace clippy, build and tests. No branch protection checks configured; authenticated reviews/comments reads empty.
Not merged: explicit instructions to this review do not authorize bread merge. Leave in review, awaiting-merge. main push publishes dev-release.yml; obtain explicit authorization and fresh head/base/check/review evidence before merge.
Independent exact-head review: PASS at
bc3b608f41. Base main7428366e71. Complete actual PR diff: one file, +2/-1; all file pages and PR pages exhausted, unique branch/card link.Criteria: ram registration and recognition test PASS (bread-shared/src/apps.rs:12-15,139-145); event and command namespace acceptance PASS (apps.rs:65-82,115-123, IPC integration breadd/src/ipc/mod.rs:310-370). Independent cargo test -p bread-shared --lib --locked: 67 passed, including 15 apps tests. cargo fmt -p bread-shared --check passed. A separate rustc probe importing the immutable apps.rs accepted bread.ram.pressure and bread.command.ram.{status,mode,action}, rejected other app namespaces, malformed ram commands and unknown targets. No unrelated churn. This accepts the bread-side registration only, not a claim of RAM-17 end-to-end deployed integration.
Required check: check / check (push), exact SHA above, success, Actions run 122 job 0. Read check.yml: workspace clippy, build and tests. No branch protection checks configured; authenticated reviews/comments reads empty.
Not merged: explicit instructions to this review do not authorize bread merge. Leave in review, awaiting-merge. main push publishes dev-release.yml; obtain explicit authorization and fresh head/base/check/review evidence before merge.
Verified on integrated main
05125ef(merge of PR35): dev release / build (push) success on the merge SHA; bread-shared tests 67 passed including 15 apps tests and the is_known_app("ram") assertion, run in a clean detached worktree at05125ef.