Removes genuinely dead code (unused import, no-op cast, an unused
PendingGrab accessor, and TmdbClient's TV-search methods now that TVDB
fully covers that path), tightens len()>0 checks to is_empty(), swaps
two fixed-size test vec!s for arrays, restructures a match to avoid an
unnecessary unwrap_err, fixes doc-comment list indentation, and hoists
a locked-connection call out of a match scrutinee. Struct fields/enum
variants that are still meaningful but not read by current callers
(TorrentInfo::save_path, GrabCycleStats::items_seen, X1337 fallback
route, BacklogCandidate::path) get #[allow(dead_code)] rather than
deletion, same for the two 8-argument functions (too_many_arguments).
- transcode_job gains is_anime/force_reencode so a job can be
re-encoded even though it's already AV1 - needed for the rate-control
bug that left ~476 files larger than their originals; the normal
backfill query skips already-AV1 files, so this is find_oversized_
av1_candidates plus a dedicated retranscode-oversized CLI command
- relink-orphaned-files: read-only reconciliation for episode_file rows
that lost their association (DB-recovery incident) despite the real
file still sitting where the importer would have put it
- qbit: delete finished torrents from qBittorrent after import instead
of relocating them with set_location, since nothing is left seeding
from the old save path after the move
Requested and applied a full review of the AV1 transcode implementation.
Findings and fixes:
- Season-pack import bypassed upgrade_locked entirely: a season pack
scored higher than a locally-transcoded file's stale release score
would silently overwrite it. Fixed in import_season_pack_file (and
mirrored into import_one for defense-in-depth) to check
upgrade_locked before the score comparison, not after.
- The post-import enqueue hook only checked anime, silently skipping
the HDR/2160p exclusions find_backlog_candidates applies to the
backfill -- a freshly-grabbed HDR file would have gone through the
unverified HDR-via-VAAPI path. Centralized all eligibility rules
(anime, already-av1, HDR, height) into transcode::should_enqueue,
used by both import_one and the newly-added season-pack enqueue
hook (season packs previously had no transcode hook at all, despite
being the actual headline use case -- 100GB+ season packs).
- find_backlog_candidates: a NULL-height row was included as a
candidate but could never actually be claimed (claim_pending_jobs
requires non-null height), permanently stuck pending. Fixed the
WHERE clause.
- encode_and_verify now probes the real input file first and skips
the encode entirely if it's already AV1 -- closes a narrow crash
window where a rename-succeeded-but-DB-update-failed job would
otherwise re-encode an already-transcoded file on retry.
- finalize_job's success path could leak a verified temp file and
strand a job in 'running' forever if a filesystem operation failed
partway through; now wrapped so any failure there cleans up and
marks the job failed like every other error path.
- reset_orphaned_running_jobs now also sweeps each reset job's
leftover temp file (job-id-scoped paths, so this lookup is
unambiguous) rather than leaking them on a disk that's usually
already tight on space.
- Added a unique index preventing two active jobs for the same file
ever existing at once -- closes the remaining gap in last commit's
concurrency fix (a daemon restart's reset could otherwise race a
still-alive transcode-library backfill onto the same file).
- Made the VAAPI rate-control mode explicit (VBR) instead of
driver-inferred.
- The daemon's transcode ticker awaited each cycle inline in the
tokio::select! loop, blocking every other cycle (import, search,
upgrade, reconcile) for the full multi-minute duration of an
encode. Now spawns each cycle detached with a try-lock guard so
overlapping ticks skip cleanly rather than stacking (the
concurrency cap from the previous commit makes this safe).
Two items reviewed and deliberately left as documented, not fixed:
mp4 sources with mov_text subtitles will fail the encode cleanly (no
data loss, just no space saved) since Matroska can't hold that codec
via stream copy -- fixing this needs per-stream codec probing that
wasn't safe to add untested at this hour. Renaming an mp4 source's
extension to .mkv after transcoding is cosmetic (Jellyfin
content-sniffs fine) and left alone.
The daemon's steady-state transcode ticker and a manually-launched
transcode-library backfill process were both independently claiming
pending jobs from the same queue with no shared concurrency
awareness, each capping only at its own parallelism_max. Combined
with large files easily outlasting the 30s poll interval, this
stacked to 20+ simultaneous GPU encode/decode sessions and triggered
the kernel OOM killer on a shared 15GB host running a dozen+ other
containers (confirmed via dmesg; no services were lost, no library
files were touched — the original-file-safety design held under the
crash).
Fixes: claim_pending_jobs now treats its limit as a total concurrency
cap (subtracting already-running jobs, wrapped in a BEGIN IMMEDIATE
transaction so this is correct across concurrent processes touching
the same database, not just within one). Added reset_orphaned_running_jobs,
called on real daemon startup, so a crash never permanently strands
job slots in 'running'. Lowered the default parallelism_max from 4
to 2 given the observed real-world memory pressure.
Post-grab async background swap, upgrade_locked flag to prevent the
upgrade loop from re-inflating a locally-transcoded file, and a
transcode-library CLI backfill for the existing catalog. Bitrate model
calibrated against Silicon Valley's real HEVC bitrate, scaled by
resolution and AV1's encoding efficiency. HDR/2160p and anime excluded
from this first pass. Jellyfin session polling throttles batch
encoding back to 1 stream during active playback.
qBittorrent's newer WebUI API returns 204 (not 200 "Ok.") on login success,
and a JSON success/failure summary (not plain "Ok."/"Fails." text) from
torrents/add — both broke against the currently deployed version. Also had
scan_tv_root move already-tracked episode files into their Season NN
subfolder instead of just recording wherever they already sat on disk.
