Removes genuinely dead code (unused import, no-op cast, an unused
PendingGrab accessor, and TmdbClient's TV-search methods now that TVDB
fully covers that path), tightens len()>0 checks to is_empty(), swaps
two fixed-size test vec!s for arrays, restructures a match to avoid an
unnecessary unwrap_err, fixes doc-comment list indentation, and hoists
a locked-connection call out of a match scrutinee. Struct fields/enum
variants that are still meaningful but not read by current callers
(TorrentInfo::save_path, GrabCycleStats::items_seen, X1337 fallback
route, BacklogCandidate::path) get #[allow(dead_code)] rather than
deletion, same for the two 8-argument functions (too_many_arguments).
These four files mix two things too interleaved to commit separately:
in-progress work on anime pipeline tuning (quality/preset/thread
config, per-pipeline parallelism caps), sampled decode verification,
and subtitle-codec-aware remuxing that predates this commit, plus a
set of correctness fixes from an independent Opus 5 review applied
directly on top of it:
- Attached-pic (cover art) streams could be probed as the real video
stream when they came first, silently replacing the actual
codec/height (ffprobe.rs)
- probe_failed rows (null codec/height) were enqueued for transcode
and could never be claimed again, due to the unique partial index -
should_enqueue now rejects them
- tokio::try_join! cancelled the sibling pipeline's in-flight
spawn_blocking encode on the first Err instead of letting it finish
- Duplicate episode_file rows for the same media only had one swept on
an upgrade swap, leaving stale rows/files behind
- File-swap and DB-write on transcode completion weren't atomic;
wrapped in a transaction and made probe-refresh failure non-fatal
- In-progress transcode temp files were visible to library scans
(video extension, no dotfile prefix) and could get imported mid-encode
- Remux temp files leaked on error paths; a Jellyfin refresh failure
failed the whole import cycle instead of just logging
- insufficient_space could false-positive when the download and
library dirs are on the same filesystem (rename is free there)
- Config validation for reference_height and min_size_reduction_pct,
which previously could silently divide-by-zero or overflow deep
inside an encode
Requested and applied a full review of the AV1 transcode implementation.
Findings and fixes:
- Season-pack import bypassed upgrade_locked entirely: a season pack
scored higher than a locally-transcoded file's stale release score
would silently overwrite it. Fixed in import_season_pack_file (and
mirrored into import_one for defense-in-depth) to check
upgrade_locked before the score comparison, not after.
- The post-import enqueue hook only checked anime, silently skipping
the HDR/2160p exclusions find_backlog_candidates applies to the
backfill -- a freshly-grabbed HDR file would have gone through the
unverified HDR-via-VAAPI path. Centralized all eligibility rules
(anime, already-av1, HDR, height) into transcode::should_enqueue,
used by both import_one and the newly-added season-pack enqueue
hook (season packs previously had no transcode hook at all, despite
being the actual headline use case -- 100GB+ season packs).
- find_backlog_candidates: a NULL-height row was included as a
candidate but could never actually be claimed (claim_pending_jobs
requires non-null height), permanently stuck pending. Fixed the
WHERE clause.
- encode_and_verify now probes the real input file first and skips
the encode entirely if it's already AV1 -- closes a narrow crash
window where a rename-succeeded-but-DB-update-failed job would
otherwise re-encode an already-transcoded file on retry.
- finalize_job's success path could leak a verified temp file and
strand a job in 'running' forever if a filesystem operation failed
partway through; now wrapped so any failure there cleans up and
marks the job failed like every other error path.
- reset_orphaned_running_jobs now also sweeps each reset job's
leftover temp file (job-id-scoped paths, so this lookup is
unambiguous) rather than leaking them on a disk that's usually
already tight on space.
- Added a unique index preventing two active jobs for the same file
ever existing at once -- closes the remaining gap in last commit's
concurrency fix (a daemon restart's reset could otherwise race a
still-alive transcode-library backfill onto the same file).
- Made the VAAPI rate-control mode explicit (VBR) instead of
driver-inferred.
- The daemon's transcode ticker awaited each cycle inline in the
tokio::select! loop, blocking every other cycle (import, search,
upgrade, reconcile) for the full multi-minute duration of an
encode. Now spawns each cycle detached with a try-lock guard so
overlapping ticks skip cleanly rather than stacking (the
concurrency cap from the previous commit makes this safe).
Two items reviewed and deliberately left as documented, not fixed:
mp4 sources with mov_text subtitles will fail the encode cleanly (no
data loss, just no space saved) since Matroska can't hold that codec
via stream copy -- fixing this needs per-stream codec probing that
wasn't safe to add untested at this hour. Renaming an mp4 source's
extension to .mkv after transcoding is cosmetic (Jellyfin
content-sniffs fine) and left alone.
Post-grab async background swap, upgrade_locked flag to prevent the
upgrade loop from re-inflating a locally-transcoded file, and a
transcode-library CLI backfill for the existing catalog. Bitrate model
calibrated against Silicon Valley's real HEVC bitrate, scaled by
resolution and AV1's encoding efficiency. HDR/2160p and anime excluded
from this first pass. Jellyfin session polling throttles batch
encoding back to 1 stream during active playback.
TVDB has no English episode title at all for some shows (entire seasons of
otherwise-English-titled shows came back Japanese-only) — using it verbatim
put unreadable-to-most-tooling script into an otherwise Latin-script library.
Falls back to the no-title filename shape instead.
Both import_one and import_season_pack_file deleted the existing
episode_file row and unlinked the on-disk file *before* link_or_copy_file
placed the new one. If the link/copy (or the free-space check) then
failed, the original content and its DB row were already gone with
nothing to fall back to.
Now the stale file is renamed to a sibling (freeing dest for the
hardlink fast path, same as before) and the DB row is left alone. Only
after the replacement is confirmed on disk are the file and the
old row cleaned up; any failure in between restores the original file
before returning the error.
