Reviewed. The em-dash cleanup on fix/em-dash-cleanup (PR #2) is substantively fine: punctuation-only edits across doc strings, comments, config examples, and the systemd unit, no logic changes, no new em dashes on added lines, clean commit message. The branch merges cleanly into main.

Blocker: CI is red. check / check (push) fails after ~3m46s on the head commit. This same check job is also failing on the current origin/main head, so the breakage looks pre-existing and not introduced by this branch, but per the merge rules a PR cannot land without a green combined status.

Next step: fix whatever is breaking check on main (separate work), then re-run CI on this branch. Once check is green and there are still no conflicts, this is a clean merge.

Leaving this in review.

Reviewed. The em-dash cleanup on `fix/em-dash-cleanup` (PR #2) is substantively fine: punctuation-only edits across doc strings, comments, config examples, and the systemd unit, no logic changes, no new em dashes on added lines, clean commit message. The branch merges cleanly into `main`. Blocker: CI is red. `check / check (push)` fails after ~3m46s on the head commit. This same `check` job is also failing on the current `origin/main` head, so the breakage looks pre-existing and not introduced by this branch, but per the merge rules a PR cannot land without a green combined status. Next step: fix whatever is breaking `check` on `main` (separate work), then re-run CI on this branch. Once `check` is green and there are still no conflicts, this is a clean merge. Leaving this in review.

Breadway commented

2026-09-09 14:02:09 +08:00

Author

Owner

Not merging. The check / check job is failing on the PR head (7056ec4), and it is also failing on main (5a98860, red since 2026-08-16), so this is a pre-existing CI break, not something this PR introduced.

The diff itself is clean: em-dash removal across breadarrd source comments, doc comments, config.example.toml, ci/build.sh echo strings, and the systemd unit, with no Rust logic changes (balanced 878/878 in-place edits). Two intentional no-value display glyphs in breadarr-tui/src/ui.rs are correctly left in place.

Blocked on infra, not on code. Once main CI is green again, rebase this branch and it should be mergeable. Leaving in review.

Not merging. The `check / check` job is failing on the PR head (`7056ec4`), and it is also failing on `main` (`5a98860`, red since 2026-08-16), so this is a pre-existing CI break, not something this PR introduced. The diff itself is clean: em-dash removal across `breadarrd` source comments, doc comments, `config.example.toml`, `ci/build.sh` echo strings, and the systemd unit, with no Rust logic changes (balanced 878/878 in-place edits). Two intentional no-value display glyphs in `breadarr-tui/src/ui.rs` are correctly left in place. Blocked on infra, not on code. Once `main` CI is green again, rebase this branch and it should be mergeable. Leaving in review.

Breadway merged commit 73deb4c848 into main

2026-09-09 14:11:57 +08:00

Breadway referenced this pull request from a commit

2026-09-09 14:11:57 +08:00

Merge pull request 'docs: remove em dashes from code and docs' (#2) from fix/em-dash-cleanup into main

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Breadway/breadarr!2

No description provided.

Rows
Columns