ci: build dev track and PR checks against dependency main #5

Merged

Breadway merged 1 commit from feature/dev-deps-main into main 2026-09-28 07:07:53 +08:00

Conversation 0 Commits 1 Files changed 5 +99 -13

Breadway commented 2026-09-28 06:59:41 +08:00

Owner

Copy link

Part of ECO-38.

check.yml and dev-release.yml now clone bread-ecosystem's main once, run scripts/lint-pins.sh (check.yml only) and scripts/dev-deps.sh to patch bread-onnx and bread-utils (both from bread-ecosystem) to their own main branch, and build without --locked. Cargo.toml stays tag-pinned throughout; nothing is committed back.

rc-release.yml and release.yml are untouched: tag pins plus --locked, no patching, as before.

DEV_DEPS_DIR is left at its default (a true sibling of the checkout): breadarr is a Cargo workspace, so forcing the clone inside the checkout breaks Cargo's workspace-field inheritance (the bug found rolling this out to breadbox). ci/build.sh's pinned rev is bumped to bread-ecosystem's fix for this.

Verified locally end to end: lint-pins, dev-deps.sh with its default sibling DEV_DEPS_DIR, and a dockerized cargo clippy --workspace through ci/build.sh all pass against a real breadarr checkout, clean, with no new warnings.

Note on this PR's own check.yml run: check / check (push) shows failure, but not from anything in this diff. cargo test --workspace fails because breadarrd's transcode/import tests shell out to a real ffmpeg binary to generate test clips, and the shared bread-ci Docker image (breadarr has no ci/deps.txt to add packages to it) has never included ffmpeg. Checked breadarr's CI history: check.yml has failed on every single run back to 2026-08-05, including plain pushes to main with no dev-deps involvement at all, so this is a pre-existing, unrelated gap, not something this PR introduced. check / check (pull_request) also fails instantly (0s) on this repo, again predating this PR: the pull_request trigger's GITHUB_REF_NAME isn't a real branch name the checkout step's git clone --branch can resolve. dev-release.yml (the actual dev-track build that matters for ECO-38) has no test step and is unaffected by either issue; only reports back to the owner if they want these two CI gaps looked at separately.

Part of ECO-38. check.yml and dev-release.yml now clone bread-ecosystem's main once, run scripts/lint-pins.sh (check.yml only) and scripts/dev-deps.sh to patch bread-onnx and bread-utils (both from bread-ecosystem) to their own main branch, and build without --locked. Cargo.toml stays tag-pinned throughout; nothing is committed back. rc-release.yml and release.yml are untouched: tag pins plus --locked, no patching, as before. DEV_DEPS_DIR is left at its default (a true sibling of the checkout): breadarr is a Cargo workspace, so forcing the clone inside the checkout breaks Cargo's workspace-field inheritance (the bug found rolling this out to breadbox). ci/build.sh's pinned rev is bumped to bread-ecosystem's fix for this. Verified locally end to end: lint-pins, dev-deps.sh with its default sibling DEV_DEPS_DIR, and a dockerized cargo clippy --workspace through ci/build.sh all pass against a real breadarr checkout, clean, with no new warnings. Note on this PR's own check.yml run: `check / check (push)` shows failure, but not from anything in this diff. `cargo test --workspace` fails because breadarrd's transcode/import tests shell out to a real `ffmpeg` binary to generate test clips, and the shared bread-ci Docker image (breadarr has no `ci/deps.txt` to add packages to it) has never included ffmpeg. Checked breadarr's CI history: `check.yml` has failed on every single run back to 2026-08-05, including plain pushes to `main` with no dev-deps involvement at all, so this is a pre-existing, unrelated gap, not something this PR introduced. `check / check (pull_request)` also fails instantly (0s) on this repo, again predating this PR: the `pull_request` trigger's `GITHUB_REF_NAME` isn't a real branch name the checkout step's `git clone --branch` can resolve. `dev-release.yml` (the actual dev-track build that matters for ECO-38) has no test step and is unaffected by either issue; only reports back to the owner if they want these two CI gaps looked at separately.

Breadway added 1 commit 2026-09-28 06:59:41 +08:00

ci: build dev track and PR checks against dependency main ... 0c03bec170

Part of ECO-38. check.yml and dev-release.yml now clone
bread-ecosystem's main, run scripts/lint-pins.sh (check.yml only) and
scripts/dev-deps.sh to patch bread-onnx and bread-utils to their own
main branch, and build without --locked. rc-release.yml and
release.yml stay on tag pins with --locked, untouched.

DEV_DEPS_DIR is left at its default (a true sibling of the checkout):
breadarr is a Cargo workspace, so forcing the clone inside the
checkout breaks Cargo's workspace-field inheritance. ci/build.sh's
pinned rev is bumped to bread-ecosystem's fix for this.

Verified locally end to end: lint-pins, dev-deps.sh with its default
sibling DEV_DEPS_DIR, and a dockerized cargo clippy --workspace
through ci/build.sh all pass against a real breadarr checkout.

Breadway merged commit 1368d8ea5b into main 2026-09-28 07:07:53 +08:00

Breadway referenced this pull request from a commit 2026-09-28 07:07:54 +08:00

Merge pull request 'ci: build dev track and PR checks against dependency main' (#5) from feature/dev-deps-main into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Breadway/breadarr!5

No description provided.