Screenshot fixtures contain the owner's real network name, location and personal tool strings #52
Labels
No labels
bug
ci
enhancement
feature
privacy
security
theme-system
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Breadway/breadbar#52
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
The sample data breadbar seeds for its
--screenshotviews (the stage and surtitle captures that bread-capture drives) is built from real, personal data instead of neutral placeholders. Every published capture of those views carries it.On
main(4c06335) the fixtures include:src/main.rs(theset_status(...)call in the screenshot setup),src/stage/mod.rs(seed_sample_notifications), and thestatus_sentencetest insrc/stage/pure.rs.screenshot_sample_widgetsinsrc/main.rs).src/main.rs,src/stage/mod.rs, plus apure.rstest).Why it matters
These captures are produced so they can be shown publicly (docs, the bos.breadway.dev site, trailers). The network name plus the city pin down where the owner studies and lives.
How it was found
While capturing the spotlight stage for the BOS trailer, the fixture text appeared in the stage, notification history and pill widget captures. Confirmed by grepping the source on main. The trailer avoided it by building a private copy with neutralised fixtures.
Confidence
High. Read directly in the source on
main. Reproduced in a capture.Suggested fix
Replace every fixture with neutral placeholders, for example "Home Wi-Fi", a build-timer widget instead of the flight, a disk-usage widget instead of the AI-usage one, "cargo build finished" for the notifications, and an invented artist and track. Update the matching
pure.rstests. Consider a test that fails if fixture strings match a small denylist.Implementation is available in PR #53 at
2e5398343f2ef2760b90db37f6575d3464d534b3. Local checks passed: cargo test --offline -p breadbar (128 tests) and Clippy. Exact-head CI is pending and waiting to run; if it fails, move this item back to TODO.