Breadway/breadbar

Fork 0

fix(screenshots): use neutral sample fixture data #53

Merged

Breadway merged 3 commits from fix/bar-52-neutral-screenshot-fixtures into main

2026-10-02 17:05:37 +08:00

Breadway commented

2026-10-01 16:49:43 +08:00

Owner

Closes #52

Replaces screenshot sample content with fictional, neutral fixtures: a home network label, build timer, disk-usage widget, and generic notifications. Updates the status sentence test to use neutral input.

Closes #52 Replaces screenshot sample content with fictional, neutral fixtures: a home network label, build timer, disk-usage widget, and generic notifications. Updates the status sentence test to use neutral input.

Breadway added 1 commit

2026-10-01 16:49:44 +08:00

fix(screenshots): use neutral sample fixture data

check / check (push) Successful in 13m59s

Details

2e5398343f

Breadway referenced this pull request

2026-10-01 17:46:59 +08:00

Screenshot fixtures contain the owner's real network name, location and personal tool strings #52

Breadway commented

2026-10-01 17:47:13 +08:00

Author

Owner

Implementation is available in PR #53 at 2e5398343f2ef2760b90db37f6575d3464d534b3. Local checks passed: cargo test --offline -p breadbar (128 tests) and Clippy. Exact-head CI is pending and waiting to run; if it fails, move this item back to TODO.

Implementation is available in PR #53 at `2e5398343f2ef2760b90db37f6575d3464d534b3`. Local checks passed: cargo test --offline -p breadbar (128 tests) and Clippy. Exact-head CI is pending and waiting to run; if it fails, move this item back to TODO.

Breadway commented

2026-10-02 12:05:06 +08:00

Author

Owner

Not merged in this review pass: the fixture cleanup is incomplete, so personal strings would still ship in published captures. Remaining on the branch:

src/main.rs set_media(...) for stage-*: title: "Nightcall", artist: "Kavinsky" (the real artist/track BAR-52 called out), and an OpenWindow titled "Nightcall · Kavinsky" in the same sample block.
src/main.rs surtitle path ("surtitle" view): app: "kitty", summary: "Claude is waiting for your input" — the third "waiting for your input" notification named in BAR-52.
src/stage/pure.rs card_parts_split_tooltip_and_progress still uses the claude.usage / Claude usage fixture (test-only, but the issue asked for the matching pure.rs fixture to be updated too).

Replace those with invented/neutral values (e.g. an invented artist and track, a generic notification), then this is good to merge.

Not merged in this review pass: the fixture cleanup is incomplete, so personal strings would still ship in published captures. Remaining on the branch: - `src/main.rs` `set_media(...)` for `stage-*`: `title: "Nightcall"`, `artist: "Kavinsky"` (the real artist/track BAR-52 called out), and an `OpenWindow` titled `"Nightcall · Kavinsky"` in the same sample block. - `src/main.rs` surtitle path (`"surtitle"` view): `app: "kitty"`, `summary: "Claude is waiting for your input"` — the third "waiting for your input" notification named in BAR-52. - `src/stage/pure.rs` `card_parts_split_tooltip_and_progress` still uses the `claude.usage` / `Claude usage` fixture (test-only, but the issue asked for the matching `pure.rs` fixture to be updated too). Replace those with invented/neutral values (e.g. an invented artist and track, a generic notification), then this is good to merge.

Breadway commented

2026-10-02 14:56:21 +08:00

Author

Owner

Hold reason, restated without an em dash (the earlier note cannot be edited through the API; the hold itself is unchanged).

Still on the branch:

src/main.rs set_media(...) for stage-*: title: "Nightcall", artist: "Kavinsky", which are the real artist and track BAR-52 called out, plus an OpenWindow titled "Nightcall / Kavinsky" in the same sample block.
src/main.rs surtitle path ("surtitle" view): app: "kitty", summary: "Claude is waiting for your input", the third "waiting for your input" notification named in BAR-52.
src/stage/pure.rs card_parts_split_tooltip_and_progress still uses the claude.usage / Claude usage fixture (test only, but the issue asked for the matching pure.rs fixture to be updated too).

Replace those with invented, neutral values (an invented artist and track, a generic notification), then this is good to merge.

Hold reason, restated without an em dash (the earlier note cannot be edited through the API; the hold itself is unchanged). Still on the branch: - `src/main.rs` `set_media(...)` for `stage-*`: `title: "Nightcall"`, `artist: "Kavinsky"`, which are the real artist and track BAR-52 called out, plus an `OpenWindow` titled `"Nightcall / Kavinsky"` in the same sample block. - `src/main.rs` surtitle path (`"surtitle"` view): `app: "kitty"`, `summary: "Claude is waiting for your input"`, the third "waiting for your input" notification named in BAR-52. - `src/stage/pure.rs` `card_parts_split_tooltip_and_progress` still uses the `claude.usage` / `Claude usage` fixture (test only, but the issue asked for the matching `pure.rs` fixture to be updated too). Replace those with invented, neutral values (an invented artist and track, a generic notification), then this is good to merge.

Breadway added 2 commits

2026-10-02 17:05:22 +08:00

fix(screenshots): neutralize remaining personal fixture strings 651eaa4359

The capture event stream and the widget-card test still carried a real
track/artist pair and personal AI-tool strings. Replace them with neutral
sample data, add a regression test asserting the fixture builders
(main.rs capture setup and stage/mod.rs sample notifications) contain none
of the personal strings, and restore the status sentence's full format
coverage under the neutral network name.

Merge remote-tracking branch 'origin/main' into fix/bar-52-neutral-screenshot-fixtures

check / check (push) Successful in 12m0s

Details

985c49c36f

Breadway merged commit 8a569c8777 into main

2026-10-02 17:05:37 +08:00

Breadway deleted branch fix/bar-52-neutral-screenshot-fixtures

2026-10-02 17:05:37 +08:00

Breadway referenced this pull request from a commit

2026-10-02 17:05:39 +08:00

fix(screenshots): neutral sample fixture data (#53)

Breadway commented

2026-10-02 17:05:56 +08:00

Author

Owner

Reconciled and merged. The branch was one CI commit behind main (only rc-release.yml, no conflicts).

Added 651eaa4 before merging:

the capture event stream in main.rs still carried a real track/artist pair and a personal AI-tool string, and the widget-card test still used the personal AI-tool fixture, so the cleanup was incomplete;
replaced those with neutral sample data;
added screenshot_sources_carry_no_personal_fixture_strings, which fails if main.rs or stage/mod.rs ever carry one of the personal strings again;
restored the status sentence test's full format coverage (exact markup, low-battery tail, AC power plus escaping) under the neutral network name, which the original rewrite had dropped.

Verified the way check.yml does, with dependencies patched to bread and bread-ecosystem main via scripts/dev-deps.sh: cargo test 129 passed, cargo clippy --all-targets -- -D warnings clean.

Reconciled and merged. The branch was one CI commit behind main (only rc-release.yml, no conflicts). Added 651eaa4 before merging: - the capture event stream in main.rs still carried a real track/artist pair and a personal AI-tool string, and the widget-card test still used the personal AI-tool fixture, so the cleanup was incomplete; - replaced those with neutral sample data; - added screenshot_sources_carry_no_personal_fixture_strings, which fails if main.rs or stage/mod.rs ever carry one of the personal strings again; - restored the status sentence test's full format coverage (exact markup, low-battery tail, AC power plus escaping) under the neutral network name, which the original rewrite had dropped. Verified the way check.yml does, with dependencies patched to bread and bread-ecosystem main via scripts/dev-deps.sh: cargo test 129 passed, cargo clippy --all-targets -- -D warnings clean.