Breadway/breadbar
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: honor x-canonical-private-synchronous hint for notification replacement #3

Merged
Breadway merged 1 commit from fix/2 into dev 2026-07-23 10:15:59 +08:00
Conversation 0 Commits 1 Files changed 1 +130
Breadway commented 2026-07-23 10:13:31 +08:00
Owner
Copy link

notify-send-based senders (e.g. breadcrumbs) fire a new process per notification, so replaces_id is always 0 — they instead tag related notifications with the x-canonical-private-synchronous hint and expect the daemon to replace whatever is currently showing from that app. breadbar was not honoring it, so a persistent (Expire::Never) critical notification like breadcrumbs' "no Wi-Fi adapter" during a suspend transition could never be superseded by a later notification, leaving it stuck until breadbar was restarted.

Fixes #2.

notify-send-based senders (e.g. breadcrumbs) fire a new process per notification, so `replaces_id` is always 0 — they instead tag related notifications with the `x-canonical-private-synchronous` hint and expect the daemon to replace whatever is currently showing from that app. breadbar was not honoring it, so a persistent (`Expire::Never`) critical notification like breadcrumbs' "no Wi-Fi adapter" during a suspend transition could never be superseded by a later notification, leaving it stuck until breadbar was restarted. Fixes #2.
Breadway added 1 commit 2026-07-23 10:13:32 +08:00 
notify-send-based senders (e.g. breadcrumbs) fire a new process per
notification, so replaces_id is always 0 — they instead tag related
notifications with the x-canonical-private-synchronous hint and expect
the daemon to replace whatever's currently showing from that app. We
weren't honoring it, so a persistent (Expire::Never) critical
notification like breadcrumbs' "no Wi-Fi adapter" during a suspend
transition could never be superseded by a later notification, leaving
it stuck until breadbar was restarted. Fixes #2.
Breadway merged commit 9b5b475036 into dev 2026-07-23 10:15:59 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Breadway/breadbar#3
No description provided.
Delete branch "fix/2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?