Remove em dashes from code and docs

Breadway commented

2026-09-09 10:03:37 +08:00

Owner

Replaces every em dash across Rust source, doc comments, the design sketch HTML, and CI workflow YAML with colons, semicolons, commas, or parentheses, chosen per-instance for what reads most naturally. Two now-playing/status display strings that previously joined title and artist (or command label and description) with an em dash were reworded to use a comma or colon instead, matching the same convention applied to similar display strings in sibling repos. Also carries along a small pending AGENTS.md "Persistent memory" note that was already staged on main before this branch was cut.

Replaces every em dash across Rust source, doc comments, the design sketch HTML, and CI workflow YAML with colons, semicolons, commas, or parentheses, chosen per-instance for what reads most naturally. Two now-playing/status display strings that previously joined title and artist (or command label and description) with an em dash were reworded to use a comma or colon instead, matching the same convention applied to similar display strings in sibling repos. Also carries along a small pending AGENTS.md "Persistent memory" note that was already staged on `main` before this branch was cut.

Breadway added 1 commit

2026-09-09 10:03:37 +08:00

docs: remove em dashes from code and docs

CI / check (pull_request) Failing after 2s

Details

b5988340c0

Breadway commented

2026-09-09 12:35:51 +08:00

Author

Owner

Reviewed. The em-dash cleanup on fix/em-dash-cleanup (PR #7) is substantively fine: punctuation-only edits across Rust source, doc comments, the design sketch HTML, and CI YAML, no logic changes, no new em dashes on added lines, clean commit message. Rewording the two now-playing / status display strings to a comma or colon is the right call and matches the rest of the pass. The branch merges cleanly into main.

Blocker: CI is red. CI / check (push) fails on the head commit. The same job is also failing on the current origin/main head, so the breakage predates this branch, but per the merge rules a PR cannot land without a green combined status.

Next step: fix CI / check on main (separate work), then re-run CI here. Once green with no conflicts, this is a clean merge.

Leaving this in review.

Reviewed. The em-dash cleanup on `fix/em-dash-cleanup` (PR #7) is substantively fine: punctuation-only edits across Rust source, doc comments, the design sketch HTML, and CI YAML, no logic changes, no new em dashes on added lines, clean commit message. Rewording the two now-playing / status display strings to a comma or colon is the right call and matches the rest of the pass. The branch merges cleanly into `main`. Blocker: CI is red. `CI / check (push)` fails on the head commit. The same job is also failing on the current `origin/main` head, so the breakage predates this branch, but per the merge rules a PR cannot land without a green combined status. Next step: fix `CI / check` on `main` (separate work), then re-run CI here. Once green with no conflicts, this is a clean merge. Leaving this in review.

Breadway commented

2026-09-09 14:02:48 +08:00

Author

Owner

Not merging. The CI / check job is failing on the PR head (b598834, fails after ~2s) and is also failing on main (46ea984, fails after ~57s), so this is a pre-existing CI break, not something this PR introduced. The fast 2s failure on the PR run points at the workflow setup (dep install or container/runner), not at a code problem.

The diff itself is clean: em-dash removal across Rust source comments, doc comments, EVENTS.md tables, README.md, the design/sketch.html sketch, and package.yml comments, with two display strings (now-playing and command-label) reworded to a comma/colon per the sibling-repo convention. Balanced 260/257 in-place edits, no logic changes, no remaining em dashes.

Note, not blocking: the branch also carries the pending AGENTS.md "Persistent memory" note (disclosed in the PR body), and AGENTS.md still says "No build/lint/test CI runs on ordinary commits or PRs" while ci.yml clearly does, that doc line is pre-existing and worth fixing in a later pass.

Blocked on infra, not on code. Once main CI is green again, rebase and it should be mergeable. Leaving in review.

Not merging. The `CI / check` job is failing on the PR head (`b598834`, fails after ~2s) and is also failing on `main` (`46ea984`, fails after ~57s), so this is a pre-existing CI break, not something this PR introduced. The fast 2s failure on the PR run points at the workflow setup (dep install or container/runner), not at a code problem. The diff itself is clean: em-dash removal across Rust source comments, doc comments, `EVENTS.md` tables, `README.md`, the `design/sketch.html` sketch, and `package.yml` comments, with two display strings (now-playing and command-label) reworded to a comma/colon per the sibling-repo convention. Balanced 260/257 in-place edits, no logic changes, no remaining em dashes. Note, not blocking: the branch also carries the pending `AGENTS.md` "Persistent memory" note (disclosed in the PR body), and `AGENTS.md` still says "No build/lint/test CI runs on ordinary commits or PRs" while `ci.yml` clearly does, that doc line is pre-existing and worth fixing in a later pass. Blocked on infra, not on code. Once `main` CI is green again, rebase and it should be mergeable. Leaving in review.

Breadway merged commit 28c07baa34 into main

2026-09-09 14:14:35 +08:00

Breadway referenced this pull request from a commit

2026-09-09 14:14:35 +08:00

Merge pull request 'Remove em dashes from code and docs' (#7) from fix/em-dash-cleanup into main

Rows
Columns

Remove em dashes from code and docs #7