ci: remove shared temp cleanup from tag release workflows

Breadway commented

2026-09-30 18:50:09 +08:00

Owner

Tag release index regeneration now clones into an invocation-specific mktemp directory and removes only that directory on exit, including failed clones or index generation. Concurrent jobs keep their own checkouts intact.

Verified YAML parsing, embedded Bash syntax, diff checks, and four concurrent mocked workflow steps with distinct clone paths. Success and failure cleanup passed while a sibling active directory survived. No release or deployment was run.

Closes #16

Tag release index regeneration now clones into an invocation-specific mktemp directory and removes only that directory on exit, including failed clones or index generation. Concurrent jobs keep their own checkouts intact. Verified YAML parsing, embedded Bash syntax, diff checks, and four concurrent mocked workflow steps with distinct clone paths. Success and failure cleanup passed while a sibling active directory survived. No release or deployment was run. Closes #16

Breadway added 1 commit

2026-09-30 18:50:10 +08:00

fix(ci): isolate tag-release index checkouts

check / check (push) Successful in 5m31s

Details

b4be88667f

Breadway referenced this pull request

2026-09-30 18:50:12 +08:00

ci: remove shared temp cleanup from tag release workflows #16

Breadway referenced this pull request from Breadway/bread-ecosystem

2026-09-30 23:51:06 +08:00

Shared CI cache path races when multiple repos release concurrently #28

Breadway commented

2026-10-02 12:05:06 +08:00

Author

Owner

Not merged in this review pass. The mktemp + trap changes are right, but the prefixes kept in this branch (/tmp/bread-ecosystem-ci-rc-XXXXXX, /tmp/bread-ecosystem-ci-release-XXXXXX) still match an older workflow's rm -rf /tmp/bread-ecosystem-ci-*, so a concurrent legacy job can still delete this checkout during the rollout window. ECO-56 asks for a prefix older workflows cannot match; the breadclip/breadmon/breadshot siblings use /tmp/bread-index-XXXXXX. Switch both workflows to such a prefix and this can merge.

Not merged in this review pass. The mktemp + trap changes are right, but the prefixes kept in this branch (`/tmp/bread-ecosystem-ci-rc-XXXXXX`, `/tmp/bread-ecosystem-ci-release-XXXXXX`) still match an older workflow's `rm -rf /tmp/bread-ecosystem-ci-*`, so a concurrent legacy job can still delete this checkout during the rollout window. ECO-56 asks for a prefix older workflows cannot match; the breadclip/breadmon/breadshot siblings use `/tmp/bread-index-XXXXXX`. Switch both workflows to such a prefix and this can merge.

Breadway merged commit 099abc9fd9 into main

2026-10-02 17:09:11 +08:00

Breadway referenced this pull request from a commit

2026-10-02 17:09:13 +08:00

ci: remove shared temp cleanup from tag release workflows (#17)

Breadway deleted branch fix/pad-16-isolated-tag-index

2026-10-02 17:09:14 +08:00

Breadway commented

2026-10-02 17:09:41 +08:00

Author

Owner

Merged. The branch was already current on main (08aff4a) and mergeable.

Verified independently:

PyYAML parses both workflows, and every embedded run block passes bash -n (rc-release.yml 4 blocks, release.yml 5 blocks).
No shared or wildcard cleanup remains: the old rm -rf /tmp/bread-ecosystem-ci-* and the fixed /tmp/bread-ecosystem-ci path are gone, replaced by per-run mktemp directories with an EXIT trap.
The trap removes only the invocation's own directory on both success and failure.
Matches the convention already merged in breadshot #11 and breadclip #18 for the release workflow.

Merged. The branch was already current on main (08aff4a) and mergeable. Verified independently: - PyYAML parses both workflows, and every embedded run block passes `bash -n` (rc-release.yml 4 blocks, release.yml 5 blocks). - No shared or wildcard cleanup remains: the old `rm -rf /tmp/bread-ecosystem-ci-*` and the fixed `/tmp/bread-ecosystem-ci` path are gone, replaced by per-run `mktemp` directories with an `EXIT` trap. - The trap removes only the invocation's own directory on both success and failure. - Matches the convention already merged in breadshot #11 and breadclip #18 for the release workflow.

Rows
Columns

ci: remove shared temp cleanup from tag release workflows #17