ci: isolate stable release ecosystem clone

Breadway commented

2026-09-30 02:07:46 +08:00

Owner

The stable release workflow still runs rm -rf /tmp/bread-ecosystem-ci and clones Breadway/bread-ecosystem into that fixed path before generating index.json. Concurrent stable releases on the shared runner can remove or overwrite another job's active clone. The dev and RC workflows already use per-run mktemp directories. Update only .forgejo/workflows/release.yml to use a unique temporary directory and clean up that directory, then verify the workflow change.

The stable release workflow still runs `rm -rf /tmp/bread-ecosystem-ci` and clones Breadway/bread-ecosystem into that fixed path before generating index.json. Concurrent stable releases on the shared runner can remove or overwrite another job's active clone. The dev and RC workflows already use per-run mktemp directories. Update only .forgejo/workflows/release.yml to use a unique temporary directory and clean up that directory, then verify the workflow change.

Breadway commented

2026-09-30 02:11:25 +08:00

Author

Owner

I picked this up briefly but stopped before committing or opening a PR to avoid overlapping another CI queue owner. The issue remains unchanged and is being returned to backlog.

Breadway referenced this issue from a pull request that will close it,

2026-09-30 02:15:13 +08:00

ci: isolate stable release ecosystem clone #9

Breadway commented

2026-09-30 02:15:22 +08:00

Author

Owner

PR #9: #9 changes the stable release job to a per-run mktemp checkout and cleans that exact directory on exit. Workflow YAML parsing, embedded shell bash -n, and git diff --check pass.

PR #9: https://git.breadway.dev/Breadway/breadshot/pulls/9 changes the stable release job to a per-run mktemp checkout and cleans that exact directory on exit. Workflow YAML parsing, embedded shell `bash -n`, and `git diff --check` pass.

Breadway commented

2026-09-30 02:17:32 +08:00

Author

Owner

Reviewed PR #9 against the issue criteria:

Give each stable release run its own ecosystem checkout: satisfied by .forgejo/workflows/release.yml:53, which creates a unique mktemp -d directory.
Remove that checkout when index generation exits: satisfied by lines 54-56, which install an EXIT trap for that exact directory before cloning and running the index script.
Limit the change to the stable release workflow: the PR changes only .forgejo/workflows/release.yml.

The changed paths prevent concurrent stable runs from deleting or overwriting a shared checkout. No behavior tests were added; the reported YAML parse, embedded bash -n, and git diff --check checks are appropriate syntax/format validation for this workflow-only change. PR head c3412b6098121e257129c694d2dd32542aa3819f is mergeable, and CI is currently pending (check / check (push), waiting to run). No code changes requested. Keeping SHOT-8 in REVIEW until CI completes.

Reviewed PR #9 against the issue criteria: 1. Give each stable release run its own ecosystem checkout: satisfied by `.forgejo/workflows/release.yml:53`, which creates a unique `mktemp -d` directory. 2. Remove that checkout when index generation exits: satisfied by lines 54-56, which install an EXIT trap for that exact directory before cloning and running the index script. 3. Limit the change to the stable release workflow: the PR changes only `.forgejo/workflows/release.yml`. The changed paths prevent concurrent stable runs from deleting or overwriting a shared checkout. No behavior tests were added; the reported YAML parse, embedded `bash -n`, and `git diff --check` checks are appropriate syntax/format validation for this workflow-only change. PR head `c3412b6098121e257129c694d2dd32542aa3819f` is mergeable, and CI is currently pending (`check / check (push)`, waiting to run). No code changes requested. Keeping SHOT-8 in REVIEW until CI completes.

Breadway closed this issue

2026-09-30 02:20:40 +08:00

Rows
Columns

ci: isolate stable release ecosystem clone #8