Reword pywal mentions across remaining bread apps and docs

Breadway commented

2026-09-26 12:29:44 +08:00

Owner

Comment/doc-only references that don't affect behaviour (none of these read ~/.cache/wal directly). Do opportunistically alongside each app's next bread-theme bump:

bread: Documentation.md, Examples.md
breadbar: README.md, src/theme.rs
breadbox: README.md
breadhelp: src/theme.rs (and stale packaging/src copy)
breadlock: src/theme_watch.rs, src/state.rs, src/main.rs comments
bread-ecosystem: README.md, upgrade.md, registry/bread-ecosystem.toml
breadway.dev: data/projects.toml, README

Part of epic PYWAL.

Comment/doc-only references that don't affect behaviour (none of these read ~/.cache/wal directly). Do opportunistically alongside each app's next bread-theme bump: - bread: Documentation.md, Examples.md - breadbar: README.md, src/theme.rs - breadbox: README.md - breadhelp: src/theme.rs (and stale packaging/src copy) - breadlock: src/theme_watch.rs, src/state.rs, src/main.rs comments - bread-ecosystem: README.md, upgrade.md, registry/bread-ecosystem.toml - breadway.dev: data/projects.toml, README Part of epic PYWAL.

Breadway commented

2026-09-26 13:08:13 +08:00

Author

Owner

All five wording PRs are open, one per repo:

bread: Breadway/bread#6
breadbar: Breadway/breadbar#25
breadbox: Breadway/breadbox#10
breadhelp: Breadway/breadhelp#3
breadlock: Breadway/breadlock#9 (closes this issue)

Skipped per scope: bread-ecosystem (explicitly out of scope, handled by the bread-theme agent). breadway.dev checked and skipped: it is a superseded old Zola site (repo has an existing dirty working tree with unrelated uncommitted changes too), the live homepage is ~/Projects/Portfolio, not this repo.

breadhelp's packaging/src copy mentioned in the issue is gitignored build output, not tracked in git, so nothing to change there beyond src/theme.rs.

All changes are comment/doc wording only. Verified with cargo build (all succeed) and cargo fmt --check (each repo has pre-existing formatting diffs in files I did not touch, left alone). Worktrees left in place at ~/Projects/-pywal for review.

All five wording PRs are open, one per repo: - bread: https://git.breadway.dev/Breadway/bread/pulls/6 - breadbar: https://git.breadway.dev/Breadway/breadbar/pulls/25 - breadbox: https://git.breadway.dev/Breadway/breadbox/pulls/10 - breadhelp: https://git.breadway.dev/Breadway/breadhelp/pulls/3 - breadlock: https://git.breadway.dev/Breadway/breadlock/pulls/9 (closes this issue) Skipped per scope: bread-ecosystem (explicitly out of scope, handled by the bread-theme agent). breadway.dev checked and skipped: it is a superseded old Zola site (repo has an existing dirty working tree with unrelated uncommitted changes too), the live homepage is ~/Projects/Portfolio, not this repo. breadhelp's packaging/src copy mentioned in the issue is gitignored build output, not tracked in git, so nothing to change there beyond src/theme.rs. All changes are comment/doc wording only. Verified with cargo build (all succeed) and cargo fmt --check (each repo has pre-existing formatting diffs in files I did not touch, left alone). Worktrees left in place at ~/Projects/<repo>-pywal for review.

Breadway commented

2026-09-26 17:52:42 +08:00

Author

Owner

Review of the five wording PRs:

breadbox#10: merged (merge commit, branch deleted).
breadhelp#3: merged (merge commit, branch deleted).
breadbar#25: one change requested. README.md:45 claims a "Catppuccin Mocha" fallback, but bread-theme falls back to its built-in bread-toned default. Fix it on fix/pywal-wording.
bread#6: blocked on CI. The check failure is pre-existing (fmt diffs in untouched bread-cli files, and the earlier unrelated branch run also red). The wording is fine and it can merge once CI is green.
breadlock#9: blocked on CI. There is a pre-existing cargo fmt --check failure at breadlock/src/state.rs:251, and origin/main has the same diff. The wording is fine and it can merge once main's fmt is fixed.

The bread-ecosystem parts of the issue (README, upgrade.md, registry) are in bread-ecosystem#36.

Moved to todo for the breadbar fix. Rework happens on the existing fix/pywal-wording branches, and the PRs stay open. Do not open second PRs.

Review of the five wording PRs: - breadbox#10: merged (merge commit, branch deleted). - breadhelp#3: merged (merge commit, branch deleted). - breadbar#25: one change requested. README.md:45 claims a "Catppuccin Mocha" fallback, but bread-theme falls back to its built-in bread-toned default. Fix it on fix/pywal-wording. - bread#6: blocked on CI. The check failure is pre-existing (fmt diffs in untouched bread-cli files, and the earlier unrelated branch run also red). The wording is fine and it can merge once CI is green. - breadlock#9: blocked on CI. There is a pre-existing `cargo fmt --check` failure at breadlock/src/state.rs:251, and origin/main has the same diff. The wording is fine and it can merge once main's fmt is fixed. The bread-ecosystem parts of the issue (README, upgrade.md, registry) are in bread-ecosystem#36. Moved to todo for the breadbar fix. Rework happens on the existing fix/pywal-wording branches, and the PRs stay open. Do not open second PRs.

Breadway commented

2026-09-27 08:12:27 +08:00

Author

Owner

Updated all 3 remaining open wording PRs per review:

breadbar#25: fixed README.md:45, the stale "Catppuccin Mocha" fallback claim, bread-theme's actual fallback is its own built-in bread-toned default palette (see palette.rs DEFAULT_COLOR1-6). Pushed to fix/pywal-wording.
bread#6: pushed a cargo fmt --all commit fixing the pre-existing repo-wide formatting drift (bread-cli, bread-module-host, bread-shared, breadd, xtask), which also exists on origin/main untouched by this PR. Verified build/clippy/test all pass locally (two pre-existing module-host-spawn test failures reproduce identically on a clean origin/main clone in this sandbox, unrelated to formatting or this change).
breadlock#9: pushed a cargo fmt --all commit fixing the pre-existing diff at src/state.rs:251. Verified cargo fmt --all -- --check, clippy, test (53 passed), and release build all clean, matching this repo's actual CI gate.

Note: both bread's and breadlock's CI runners are still showing "Failing after Xs" (single-digit to ~20s) after these pushes, too fast to be a real clippy/test run, consistent with the open hestia CI-runner issue rather than anything in these commits. Local verification is clean and matches (or exceeds, for breadlock which actually runs fmt --check in CI) what each repo's CI runs.

breadbox#10 and breadhelp#3 are already merged; removed their worktrees (~/Projects/breadbox-pywal, ~/Projects/breadhelp-pywal) and deleted the local fix/pywal-wording branches in both repos.

PRs: Breadway/breadbar#25, Breadway/bread#6, Breadway/breadlock#9

Updated all 3 remaining open wording PRs per review: - breadbar#25: fixed README.md:45, the stale "Catppuccin Mocha" fallback claim, bread-theme's actual fallback is its own built-in bread-toned default palette (see palette.rs DEFAULT_COLOR1-6). Pushed to fix/pywal-wording. - bread#6: pushed a cargo fmt --all commit fixing the pre-existing repo-wide formatting drift (bread-cli, bread-module-host, bread-shared, breadd, xtask), which also exists on origin/main untouched by this PR. Verified build/clippy/test all pass locally (two pre-existing module-host-spawn test failures reproduce identically on a clean origin/main clone in this sandbox, unrelated to formatting or this change). - breadlock#9: pushed a cargo fmt --all commit fixing the pre-existing diff at src/state.rs:251. Verified cargo fmt --all -- --check, clippy, test (53 passed), and release build all clean, matching this repo's actual CI gate. Note: both bread's and breadlock's CI runners are still showing "Failing after Xs" (single-digit to ~20s) after these pushes, too fast to be a real clippy/test run, consistent with the open hestia CI-runner issue rather than anything in these commits. Local verification is clean and matches (or exceeds, for breadlock which actually runs fmt --check in CI) what each repo's CI runs. breadbox#10 and breadhelp#3 are already merged; removed their worktrees (~/Projects/breadbox-pywal, ~/Projects/breadhelp-pywal) and deleted the local fix/pywal-wording branches in both repos. PRs: https://git.breadway.dev/Breadway/breadbar/pulls/25, https://git.breadway.dev/Breadway/bread/pulls/6, https://git.breadway.dev/Breadway/breadlock/pulls/9

Breadway commented

2026-09-27 08:35:47 +08:00

Author

Owner

Second-round review:

breadbar#25: merged (squash, branch deleted). CI was green, and the README fallback wording is now correct.
bread#6: wording and fmt are clean, but it is not merged. CI is red for a pre-existing, non-runner reason: two breadd/tests/ipc_integration.rs tests cannot find bread-module-host, because resolve_module_host_binary (breadd/src/module_host.rs:377-387) looks next to target/debug/deps/, not target/debug/. It fails the same way on the unrelated run 95. bread is also release-sensitive, so the user lands it.
breadlock#9: wording and fmt are clean, but it is not merged. CI dies in 4 s at pacman: target not found: clippy (.forgejo/workflows/ci.yml:21; Arch folded clippy/rustfmt into rust). main is red the same way.

The earlier "hestia runner" diagnosis does not hold for either repo. Both need a small separate CI fix in their own repo, and then these PRs can merge. ECO-34 stays in review until they do.

Second-round review: - breadbar#25: merged (squash, branch deleted). CI was green, and the README fallback wording is now correct. - bread#6: wording and fmt are clean, but it is not merged. CI is red for a pre-existing, non-runner reason: two `breadd/tests/ipc_integration.rs` tests cannot find `bread-module-host`, because `resolve_module_host_binary` (`breadd/src/module_host.rs:377-387`) looks next to `target/debug/deps/`, not `target/debug/`. It fails the same way on the unrelated run 95. bread is also release-sensitive, so the user lands it. - breadlock#9: wording and fmt are clean, but it is not merged. CI dies in 4 s at `pacman: target not found: clippy` (`.forgejo/workflows/ci.yml:21`; Arch folded clippy/rustfmt into `rust`). main is red the same way. The earlier "hestia runner" diagnosis does not hold for either repo. Both need a small separate CI fix in their own repo, and then these PRs can merge. ECO-34 stays in review until they do.

Breadway commented

2026-09-28 13:03:54 +08:00

Author

Owner

Round-3 CI fixes pushed to unblock the two remaining wording PRs:

bread#6: fixed properly. The failure was not just a path-resolution bug: cargo test --workspace never actually links bread-module-host's binary (only its own unit-test harness), so resolve_module_host_binary had nothing to find regardless of which directory it searched. spawn_with_module now runs cargo build -p bread-module-host --locked once before spawning anything. Reproduced this repo's actual CI container to verify. CI is now green: https://git.breadway.dev/Breadway/bread/actions/runs/99
breadlock#9: two fixes. ci.yml no longer asks pacman for clippy/rustfmt as separate packages (folded into rust now). That got CI far enough to hit a second, also pre-existing issue: a newer clippy in the CI container's rust package flags blit_to_shm's chunks_exact_mut(4) (clippy::chunks_exact_to_as_chunks); fixed with clippy's own suggested as_chunks_mut::<4>(). CI was still starting as of the last check; will confirm.

Both are release-sensitive repos (bread, breadlock), so merge stays with the user. Staying in review.

Round-3 CI fixes pushed to unblock the two remaining wording PRs: - bread#6: fixed properly. The failure was not just a path-resolution bug: cargo test --workspace never actually links bread-module-host's binary (only its own unit-test harness), so resolve_module_host_binary had nothing to find regardless of which directory it searched. spawn_with_module now runs `cargo build -p bread-module-host --locked` once before spawning anything. Reproduced this repo's actual CI container to verify. CI is now green: https://git.breadway.dev/Breadway/bread/actions/runs/99 - breadlock#9: two fixes. ci.yml no longer asks pacman for clippy/rustfmt as separate packages (folded into rust now). That got CI far enough to hit a second, also pre-existing issue: a newer clippy in the CI container's rust package flags blit_to_shm's chunks_exact_mut(4) (clippy::chunks_exact_to_as_chunks); fixed with clippy's own suggested as_chunks_mut::<4>(). CI was still starting as of the last check; will confirm. Both are release-sensitive repos (bread, breadlock), so merge stays with the user. Staying in review.

Breadway commented

2026-09-29 08:13:00 +08:00

Author

Owner

Post-merge review of the round-3 CI fixes. bread#6: acceptable, but a follow-up fix PR is recommended (Breadway/bread#6 (comment)). module_host_sandbox.rs never calls ensure_module_host_built and only passes because of test ordering. Run alone on a fresh target dir, it fails and falls back to the installed ~/.local/bin/bread-module-host through PATH. The nested build also ignores --release, --target-dir and --target. breadlock#9: fine, since as_chunks_mut is stable since 1.88 and all toolchains in use are newer (Breadway/breadlock#9 (comment)). Optional follow-up: add rust-version = "1.88".

Post-merge review of the round-3 CI fixes. bread#6: acceptable, but a follow-up fix PR is recommended (https://git.breadway.dev/Breadway/bread/pulls/6#issuecomment-1392). module_host_sandbox.rs never calls ensure_module_host_built and only passes because of test ordering. Run alone on a fresh target dir, it fails and falls back to the installed ~/.local/bin/bread-module-host through PATH. The nested build also ignores --release, --target-dir and --target. breadlock#9: fine, since as_chunks_mut is stable since 1.88 and all toolchains in use are newer (https://git.breadway.dev/Breadway/breadlock/pulls/9#issuecomment-1393). Optional follow-up: add rust-version = "1.88".

Breadway closed this issue

2026-09-29 13:24:26 +08:00

Rows
Columns

Reword pywal mentions across remaining bread apps and docs #34