Breadway/breadbar
1
0
Fork 0
Code Issues 3 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Reword pywal references to bread-theme #25

Merged
Breadway merged 2 commits from fix/pywal-wording into main 2026-09-27 08:32:53 +08:00
Conversation 1 Commits 2 Files changed 2 +7 -7
Breadway commented 2026-09-26 13:07:47 +08:00
Owner
Copy link

Part of ECO-34.

README and src/theme.rs comments described the palette source as pywal
(~/.cache/wal/colors.json). bread-theme now owns its own native palette
cache and only falls back to a pywal colors.json for backward
compatibility, per the epic PYWAL contract. Wording only, no behaviour
change.

Verified: cargo build succeeds. cargo fmt --check reports pre-existing
formatting diffs in src/bar/bluetooth.rs and src/bar/control.rs unrelated to
this change (no code touched in either file), left alone to keep this PR
scoped to wording.

Part of ECO-34. README and src/theme.rs comments described the palette source as pywal (`~/.cache/wal/colors.json`). bread-theme now owns its own native palette cache and only falls back to a pywal `colors.json` for backward compatibility, per the epic PYWAL contract. Wording only, no behaviour change. Verified: `cargo build` succeeds. `cargo fmt --check` reports pre-existing formatting diffs in src/bar/bluetooth.rs and src/bar/control.rs unrelated to this change (no code touched in either file), left alone to keep this PR scoped to wording.
docs: reword pywal references to bread-theme
All checks were successful
check / check (push) Successful in 34s
Details
1ffc5bd379 
README and src/theme.rs comments described the palette source as
pywal (~/.cache/wal/colors.json); bread-theme now owns a native
palette cache and only falls back to a pywal colors.json for
compatibility. Wording only, no behaviour change.

Part of ECO-34.
Breadway commented 2026-09-26 17:52:30 +08:00
Author
Owner
Copy link

Review: one wording fix requested (not merging yet)

CI is green and the PR is mergeable. The src/theme.rs comment rewording is accurate.

  • README.md:45 states a false fallback. It says "...and a Catppuccin Mocha palette if neither is found". bread-theme's load_palette() falls back to Palette::default(): the fixed BOS dark base plus the curated bread-toned accents (#b98749 ... #eabe82, bread-theme/src/palette.rs:20-25). It is not Catppuccin Mocha, and breadbar has no Catppuccin fallback of its own (nothing in src/). The wrong claim predates this PR, but the PR rewrote the line and kept it. Change it to something like "and bread-theme's built-in default palette (fixed BOS dark base, bread-toned accents) if neither is found".

The fallback to a pywal colors.json matches what bread-theme does on bread-ecosystem#36 (load_palette reads palette.json, then ~/.cache/wal/colors.json).

Rework happens on the existing branch fix/pywal-wording, and this PR stays open. Do not open a second PR for ECO-34.

## Review: one wording fix requested (not merging yet) CI is green and the PR is mergeable. The src/theme.rs comment rewording is accurate. - [ ] **`README.md:45` states a false fallback.** It says "...and a Catppuccin Mocha palette if neither is found". bread-theme's `load_palette()` falls back to `Palette::default()`: the fixed BOS dark base plus the curated bread-toned accents (`#b98749 ... #eabe82`, `bread-theme/src/palette.rs:20-25`). It is not Catppuccin Mocha, and breadbar has no Catppuccin fallback of its own (nothing in `src/`). The wrong claim predates this PR, but the PR rewrote the line and kept it. Change it to something like "and bread-theme's built-in default palette (fixed BOS dark base, bread-toned accents) if neither is found". The fallback to a pywal `colors.json` matches what bread-theme does on bread-ecosystem#36 (`load_palette` reads `palette.json`, then `~/.cache/wal/colors.json`). Rework happens on the existing branch `fix/pywal-wording`, and this PR stays open. Do not open a second PR for ECO-34.
docs: fix stale Catppuccin Mocha fallback wording in README
All checks were successful
check / check (push) Successful in 22s
Details
00a0358c5f 
bread-theme's built-in fallback is its own bread-toned default palette,
not Catppuccin Mocha.
Breadway deleted branch fix/pywal-wording 2026-09-27 08:32:53 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
ci

   
enhancement

   
feature

   
privacy

   
security

   
theme-system
No labels
bug
ci
enhancement
feature
privacy
security
theme-system
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Breadway/breadbar!25
No description provided.