Server ignores SIGTERM, so every container stop waits 10s and ends in SIGKILL #81

Merged

Breadway merged 2 commits from fix/bb-91-sigterm into main

2026-10-08 19:54:27 +08:00

Breadway commented

2026-10-01 17:50:05 +08:00

Owner

Handle SIGTERM alongside Ctrl-C so container shutdown starts promptly. Signal active SSE responses to close, allowing graceful shutdown to finish with connected clients.

Verified with cargo build --workspace, cargo test --workspace, cargo clippy --workspace --all-targets -- -D warnings, and cargo run -p xtask -- check-docs. cargo fmt --all -- --check reports existing formatting drift in untouched files.

Closes #78

Handle SIGTERM alongside Ctrl-C so container shutdown starts promptly. Signal active SSE responses to close, allowing graceful shutdown to finish with connected clients. Verified with `cargo build --workspace`, `cargo test --workspace`, `cargo clippy --workspace --all-targets -- -D warnings`, and `cargo run -p xtask -- check-docs`. `cargo fmt --all -- --check` reports existing formatting drift in untouched files. Closes #78

Breadway added 1 commit

2026-10-01 17:50:08 +08:00

fix(server): handle SIGTERM during shutdown

check / check (push) Failing after 2m42s

Details

26c7e09d35

Breadway referenced this pull request

2026-10-01 17:50:25 +08:00

Server ignores SIGTERM, so every container stop waits 10s and ends in SIGKILL #78

Breadway commented

2026-10-01 17:55:31 +08:00

Author

Owner

Implementation is available in PR #81 at 26c7e09d35108b3c602da26907151636aa7569fd. Local verification passed: workspace build, tests, Clippy, check-docs, and diff-check. Exact-head CI is pending and waiting to run; if it fails, move this card back to TODO.

Implementation is available in PR #81 at `26c7e09d35108b3c602da26907151636aa7569fd`. Local verification passed: workspace build, tests, Clippy, check-docs, and diff-check. Exact-head CI is pending and waiting to run; if it fails, move this card back to TODO.

Breadway commented

2026-10-02 12:01:07 +08:00

Author

Owner

Not merged in this review pass. #82 (authenticate /events) and #79 (close SSE on broadcast lag) both edit the same events handler and are now merged, so this branch conflicts in crates/breadboard-server/src/http.rs. Additionally, the new tests/shutdown.rs opens /events without credentials and asserts success; after #82 that request returns 401, so the test also needs auth (e.g. a bearer header or the session cookie). Rebase on main, send auth in the SSE request, and this is good to merge.

Not merged in this review pass. #82 (authenticate /events) and #79 (close SSE on broadcast lag) both edit the same `events` handler and are now merged, so this branch conflicts in `crates/breadboard-server/src/http.rs`. Additionally, the new `tests/shutdown.rs` opens `/events` without credentials and asserts success; after #82 that request returns 401, so the test also needs auth (e.g. a bearer header or the session cookie). Rebase on main, send auth in the SSE request, and this is good to merge.

Breadway force-pushed fix/bb-91-sigterm from 26c7e09d35

check / check (push) Failing after 2m42s

Details

to 707b758588

check / check (push) Successful in 1m17s

Details

2026-10-08 19:46:11 +08:00

Compare

Breadway referenced this pull request

2026-10-08 19:46:33 +08:00

Server ignores SIGTERM, so every container stop waits 10s and ends in SIGKILL #78

Breadway merged commit 5ff90e8cc2 into main