ci: make the bread-ecosystem clone in ci/build.sh race-free #18

Closed

Breadway wants to merge 1 commit from fix/ci-clone-race into main

Breadway commented

2026-09-29 17:27:54 +08:00

Owner

The runner shares /tmp between concurrent jobs. This script cloned bread-ecosystem into /tmp/bread-ecosystem-ci- with a non-atomic check-then-clone and, in most apps, a glob rm -rf that could delete a checkout another job was building from.

The clone now goes into a private temp dir, is marked .ready and renamed into place under a lock. Other revs are pruned only after a day unused. Tested locally with four concurrent jobs against a fake repo: all built from complete checkouts, a recently used checkout survived, and only a stale one was pruned.

Follow-up to ECO-38.

The runner shares /tmp between concurrent jobs. This script cloned bread-ecosystem into /tmp/bread-ecosystem-ci-<rev> with a non-atomic check-then-clone and, in most apps, a glob rm -rf that could delete a checkout another job was building from. The clone now goes into a private temp dir, is marked .ready and renamed into place under a lock. Other revs are pruned only after a day unused. Tested locally with four concurrent jobs against a fake repo: all built from complete checkouts, a recently used checkout survived, and only a stale one was pruned. Follow-up to ECO-38.

Breadway added 1 commit

2026-09-29 17:27:56 +08:00

ci: make the bread-ecosystem clone in ci/build.sh race-free

check / check (push) Failing after 4m20s

Details

4987be672f

The runner's /tmp is shared by concurrent jobs. This script cloned
bread-ecosystem into /tmp/bread-ecosystem-ci-<rev> with a check-then-clone
that was not atomic, and (in most apps) a glob rm -rf of
/tmp/bread-ecosystem-ci-* that could delete a checkout another job was
building from. A job could also start from a half-cloned tree.

The clone now goes into a private temp dir, is marked .ready and renamed
into place under a lock, so a job sees a complete checkout or none, and
two jobs never clone the same rev at once. Nothing deletes a checkout that
may be in use: other revs are pruned only after a day unused, and every run
touches its own. Adds BREAD_CI_TMP and BREAD_ECOSYSTEM_URL overrides so the
logic can be tested without the network. Follow-up to ECO-38.

Breadway referenced this pull request

2026-09-29 20:31:32 +08:00

ci: race-free clone in ci/build.sh; bump ci/bread-ecosystem.rev #19

Breadway commented

2026-09-29 20:40:45 +08:00

Author

Owner

Superseded by #19, which carries both changes on a fresh main and passed its check.

Breadway closed this pull request

2026-09-29 20:40:45 +08:00