Reword pywal references to bread-theme in comments #9

Merged

Breadway merged 4 commits from fix/pywal-wording into main 2026-09-28 13:10:19 +08:00

Conversation 5 Commits 4 Files changed 5 +14 -10

Breadway commented 2026-09-26 13:07:59 +08:00

Owner

Copy link

Closes ECO-34.

main.rs, state.rs, and theme_watch.rs described the per-output palette cache
invalidation as reacting to "pywal regenerating" the palette files.
bread-theme now extracts and writes palettes natively, and pywal is being
removed across the ecosystem. Comment only, no behaviour change.

This is the last of the ECO-34 wording PRs (bread #6, breadbox #10,
breadhelp #3, breadbar #25 also open).

Verified: cargo build succeeds. cargo fmt --check reports one
pre-existing formatting diff in src/state.rs (an unrelated AuthState
match arm), left alone to keep this PR scoped to wording.

Closes ECO-34. main.rs, state.rs, and theme_watch.rs described the per-output palette cache invalidation as reacting to "pywal regenerating" the palette files. bread-theme now extracts and writes palettes natively, and pywal is being removed across the ecosystem. Comment only, no behaviour change. This is the last of the ECO-34 wording PRs (bread #6, breadbox #10, breadhelp #3, breadbar #25 also open). Verified: `cargo build` succeeds. `cargo fmt --check` reports one pre-existing formatting diff in src/state.rs (an unrelated `AuthState` match arm), left alone to keep this PR scoped to wording.

Breadway added 1 commit 2026-09-26 13:07:59 +08:00

docs: reword pywal references to bread-theme in comments ... 744edbef64

main.rs, state.rs, and theme_watch.rs described the per-output palette
cache invalidation as reacting to "pywal regenerating" the palette
files; bread-theme now extracts and writes palettes natively. Comment
only, no behaviour change.

Closes ECO-34.

Breadway referenced this pull request from Breadway/bread-ecosystem 2026-09-26 13:08:13 +08:00

Reword pywal mentions across remaining bread apps and docs #34

Breadway commented 2026-09-26 17:52:38 +08:00

Author

Owner

Copy link

Review: blocked on CI (wording itself is fine)

The comment rewording in main.rs, state.rs and theme_watch.rs is accurate. But CI / check (pull_request) failed on 744edbe, and I do not merge on red CI.

The cause is pre-existing. The workflow runs cargo fmt --all -- --check, which fails on breadlock/src/state.rs:251: rustfmt wants "PAM config error: ...".to_string(), joined onto one line. A clean worktree of origin/main has the same single fmt diff, and main's own CI / check (push) is red. This PR's edits to state.rs are doc-comment only and do not cause it.

Fix the fmt on main in a separate fix/ branch (or, if you prefer, include the one-line cargo fmt fix here), then re-run. It can merge once CI is green.

Note: design/sketch.html still says "pywal" in several places (lines 11, 13, 343, 348, 528-529). It was outside ECO-34's listed scope, so it is not required here.

## Review: blocked on CI (wording itself is fine) The comment rewording in main.rs, state.rs and theme_watch.rs is accurate. But `CI / check (pull_request)` failed on 744edbe, and I do not merge on red CI. The cause is pre-existing. The workflow runs `cargo fmt --all -- --check`, which fails on `breadlock/src/state.rs:251`: rustfmt wants `"PAM config error: ...".to_string(),` joined onto one line. A clean worktree of `origin/main` has the same single fmt diff, and `main`'s own `CI / check (push)` is red. This PR's edits to state.rs are doc-comment only and do not cause it. Fix the fmt on main in a separate `fix/` branch (or, if you prefer, include the one-line `cargo fmt` fix here), then re-run. It can merge once CI is green. Note: `design/sketch.html` still says "pywal" in several places (lines 11, 13, 343, 348, 528-529). It was outside ECO-34's listed scope, so it is not required here.

Breadway added 1 commit 2026-09-27 08:11:38 +08:00

chore: fix pre-existing cargo fmt drift ... e4696bccc1

Whitespace only, in an AuthState match arm this PR does not touch.
This drift already existed on main; fixing it here so the CI format
gate goes green for this branch.

Breadway commented 2026-09-27 08:11:48 +08:00

Author

Owner

Copy link

Pushed a cargo fmt --all commit fixing the pre-existing formatting diff at src/state.rs:251 (an AuthState match arm this PR does not touch), matching this repo's cargo fmt --all -- --check CI gate. Whitespace only.

Verified: cargo fmt --all -- --check (clean), cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace --all-targets (53 passed), cargo build --release --locked, all clean.

Pushed a `cargo fmt --all` commit fixing the pre-existing formatting diff at src/state.rs:251 (an AuthState match arm this PR does not touch), matching this repo's `cargo fmt --all -- --check` CI gate. Whitespace only. Verified: cargo fmt --all -- --check (clean), cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace --all-targets (53 passed), cargo build --release --locked, all clean.

Breadway referenced this pull request from Breadway/bread-ecosystem 2026-09-27 08:12:27 +08:00

Reword pywal mentions across remaining bread apps and docs #34

Breadway commented 2026-09-27 08:35:43 +08:00

Author

Owner

Copy link

Second-round review: wording is clean, blocked on CI (not merging)

The diff is fine. The comment rewording in main.rs, state.rs and theme_watch.rs is accurate, and e4696bc is a formatting-only rustfmt change.

The CI failure is in the workflow, not the runner. Run 25 fails after 4 s in the Install build deps step, before any cargo command runs: pacman: error: target not found: clippy. .forgejo/workflows/ci.yml:21 installs rust cargo clippy rustfmt with pacman on archlinux:latest. Arch no longer has separate clippy/rustfmt packages (they ship inside rust), and the cargo/rustfmt names now prompt for a provider (rust or rustup). main is red the same way (run 21, 2026-09-11), so this is pre-existing. Fix, for a separate issue: install just rust (plus the other build deps) in ci.yml. This PR stays open until the check is green.

## Second-round review: wording is clean, blocked on CI (not merging) The diff is fine. The comment rewording in main.rs, state.rs and theme_watch.rs is accurate, and e4696bc is a formatting-only rustfmt change. **The CI failure is in the workflow, not the runner.** Run 25 fails after 4 s in the `Install build deps` step, before any cargo command runs: `pacman: error: target not found: clippy`. `.forgejo/workflows/ci.yml:21` installs `rust cargo clippy rustfmt` with pacman on `archlinux:latest`. Arch no longer has separate `clippy`/`rustfmt` packages (they ship inside `rust`), and the `cargo`/`rustfmt` names now prompt for a provider (rust or rustup). main is red the same way (run 21, 2026-09-11), so this is pre-existing. Fix, for a separate issue: install just `rust` (plus the other build deps) in ci.yml. This PR stays open until the check is green.

Breadway added 1 commit 2026-09-28 01:27:03 +08:00

ci: stop asking pacman for the nonexistent clippy/rustfmt packages ... 8a7a570162

.forgejo/workflows/ci.yml installed `clippy` and `rustfmt` as separate
pacman packages. Current Arch's `rust` package provides both directly
(cargo-clippy/clippy-driver/rustfmt are all files in the `rust` package
now; confirmed against the live extra/rust package info, which also lists
`rustfmt` under Provides), so pacman fails the whole install step with
"target not found: clippy" and CI dies in a few seconds before it ever
reaches a real build.

This is a pre-existing CI break also present on main, unrelated to this
branch's wording changes.

Verified: cargo fmt --all -- --check, cargo clippy --workspace
--all-targets -- -D warnings, cargo test --workspace --all-targets
(20 passed), cargo build --release --locked, matching this repo's actual
CI gate (ci.yml) exactly.

Breadway added 1 commit 2026-09-28 13:03:15 +08:00

fix: use as_chunks_mut instead of chunks_exact_mut in blit_to_shm ... eb54108639

Reproduced this repo's actual CI failure in its own pinned container
(archlinux:latest, after the previous commit's pacman fix let it get past
the install step): clippy::chunks_exact_to_as_chunks now fires on
blit_to_shm's shm_bytes.chunks_exact_mut(4), because the container's
current rust package (1.98.1) ships a newer clippy (0.1.98) than this
sandbox's own toolchain (0.1.97), which doesn't have that lint yet. Applied
clippy's own suggested fix.

This line is unchanged on main (verified against origin/main), so it is
pre-existing CI breakage that any push against a fresh CI container would
now hit, not something introduced by this branch's wording changes.

Verified: cargo build (dev and release --locked), cargo test --workspace
--all-targets (all green, including render::tests::blit_swizzles_rgba_to_bgra
for both the breadlock and breadlock-preview binaries, confirming identical
behaviour), cargo clippy --workspace --all-targets -- -D warnings, cargo
fmt --all -- --check.

Breadway commented 2026-09-28 13:03:45 +08:00

Author

Owner

Copy link

Round-3: two commits fixing pre-existing CI breakage blocking this PR (both also present on main, unrelated to the wording changes here).

1. .forgejo/workflows/ci.yml: stopped asking pacman for clippy/rustfmt as separate packages. Current Arch's rust package provides both directly (confirmed against the live extra/rust package info: Provides: cargo rustfmt, plus cargo-clippy/clippy-driver/rustfmt all listed as files owned by rust), so the install step was failing outright with "target not found: clippy" before any real build ever ran.
2. After that fix got CI far enough to actually build: clippy::chunks_exact_to_as_chunks now fires on blit_to_shm's shm_bytes.chunks_exact_mut(4) in breadlock/src/render.rs, because the CI container's rust package (1.98.1) ships a newer clippy than what had last verified this line. Applied clippy's own suggested fix (as_chunks_mut::<4>()); this line is unchanged on origin/main, confirming it's pre-existing drift, not something this branch introduced.

Verified both fixes against this repo's actual CI container (fresh archlinux:latest, not just local toolchain, which still has an older clippy that doesn't have the new lint): cargo fmt --all -- --check, cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace --all-targets (all green, including render::tests::blit_swizzles_rgba_to_bgra for both breadlock and breadlock-preview), cargo build --release --locked.

CI on this push was still starting up as of this comment; will confirm once it completes.

Round-3: two commits fixing pre-existing CI breakage blocking this PR (both also present on main, unrelated to the wording changes here). 1. `.forgejo/workflows/ci.yml`: stopped asking pacman for `clippy`/`rustfmt` as separate packages. Current Arch's `rust` package provides both directly (confirmed against the live `extra/rust` package info: `Provides: cargo rustfmt`, plus `cargo-clippy`/`clippy-driver`/`rustfmt` all listed as files owned by `rust`), so the install step was failing outright with "target not found: clippy" before any real build ever ran. 2. After that fix got CI far enough to actually build: `clippy::chunks_exact_to_as_chunks` now fires on `blit_to_shm`'s `shm_bytes.chunks_exact_mut(4)` in `breadlock/src/render.rs`, because the CI container's `rust` package (1.98.1) ships a newer clippy than what had last verified this line. Applied clippy's own suggested fix (`as_chunks_mut::<4>()`); this line is unchanged on `origin/main`, confirming it's pre-existing drift, not something this branch introduced. Verified both fixes against this repo's actual CI container (fresh `archlinux:latest`, not just local toolchain, which still has an older clippy that doesn't have the new lint): `cargo fmt --all -- --check`, `cargo clippy --workspace --all-targets -- -D warnings`, `cargo test --workspace --all-targets` (all green, including `render::tests::blit_swizzles_rgba_to_bgra` for both `breadlock` and `breadlock-preview`), `cargo build --release --locked`. CI on this push was still starting up as of this comment; will confirm once it completes.

Breadway merged commit 05574a088c into main 2026-09-28 13:10:19 +08:00

Breadway deleted branch fix/pywal-wording 2026-09-28 13:10:19 +08:00

Breadway referenced this pull request from a commit 2026-09-28 13:10:21 +08:00

Merge pull request 'Reword pywal references to bread-theme in comments' (#9) from fix/pywal-wording into main

Breadway commented 2026-09-29 08:12:40 +08:00

Author

Owner

Copy link

Post-merge review of the round-3 commits (8a7a570, eb54108): fine, one optional follow-up

Main (05574a0) is green (CI / check).

• ci.yml: dropping clippy/rustfmt from the pacman line is correct. Arch's rust package ships cargo-clippy and rustfmt. Keeping cargo in the list is harmless, since rust provides it.
• render.rs blit_to_shm, as_chunks_mut::<4>(): slice::as_chunks_mut has been stable since Rust 1.88 (June 2025). Every toolchain that builds breadlock is newer: the CI archlinux:latest container (rust 1.98.x per your note), package.yml (same image), the PKGBUILD's makedepends=('rust' 'cargo') on rolling Arch, and this workstation's 1.97.1, where I re-ran cargo clippy --workspace --all-targets --locked -- -D warnings clean. Behaviour is unchanged: exact 4-byte chunks, the remainder is ignored as before, and render::tests::blit_swizzles_rgba_to_bgra still covers the swizzle.
• Optional follow-up: none of the workspace crates declares rust-version. Adding rust-version = "1.88" to the breadlock, breadlock-ui and breadgreet manifests turns an old-toolchain build into a clear MSRV error instead of an "unstable feature" one.

No fix PR needed.

## Post-merge review of the round-3 commits (8a7a570, eb54108): fine, one optional follow-up Main (05574a0) is green (`CI / check`). - **ci.yml:** dropping `clippy`/`rustfmt` from the pacman line is correct. Arch's `rust` package ships cargo-clippy and rustfmt. Keeping `cargo` in the list is harmless, since `rust` provides it. - **`render.rs` `blit_to_shm`, `as_chunks_mut::<4>()`:** `slice::as_chunks_mut` has been stable since Rust 1.88 (June 2025). Every toolchain that builds breadlock is newer: the CI `archlinux:latest` container (rust 1.98.x per your note), `package.yml` (same image), the PKGBUILD's `makedepends=('rust' 'cargo')` on rolling Arch, and this workstation's 1.97.1, where I re-ran `cargo clippy --workspace --all-targets --locked -- -D warnings` clean. Behaviour is unchanged: exact 4-byte chunks, the remainder is ignored as before, and `render::tests::blit_swizzles_rgba_to_bgra` still covers the swizzle. - **Optional follow-up:** none of the workspace crates declares `rust-version`. Adding `rust-version = "1.88"` to the breadlock, breadlock-ui and breadgreet manifests turns an old-toolchain build into a clear MSRV error instead of an "unstable feature" one. No fix PR needed.

Breadway referenced this pull request from Breadway/bread-ecosystem 2026-09-29 08:13:00 +08:00

Reword pywal mentions across remaining bread apps and docs #34

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Breadway/breadlock!9

No description provided.